[PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
@ 2023-01-07 15:16 Jan Engelhardt
  2023-01-07 18:22 ` [edk2-devel] " Michael D Kinney
  2023-01-20 15:57 ` Michael D Kinney
  0 siblings, 2 replies; 6+ messages in thread
From: Jan Engelhardt @ 2023-01-07 15:16 UTC (permalink / raw)
  To: devel

Signed-off-by: Jan Engelhardt <jengelh@inai.de>
---
This was previously posted to https://github.com/tianocore/edk2/pull/3330
where you can see a visual representation of what is being corrected.

 .../Universal/Console/GraphicsConsoleDxe/LaffStd.c     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
index 1f7fe4cda8..99d909592c 100644
--- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
+++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
@@ -213,13 +213,13 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
   },
   { 0x00a3,                                     0x00, { 0x00, 0x00, 0x00, 0x38, 0x6C, 0x64, 0x60, 0x60, 0xF0, 0x60, 0x60, 0x60, 0x60, 0xE6, 0xFC, 0x00, 0x00, 0x00, 0x00 }
   },
-  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x18, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6, 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
+  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6, 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
   },
   { 0x00a5,                                     0x00, { 0x00, 0x00, 0x00, 0x66, 0x66, 0x66, 0x3C, 0x18, 0x7E, 0x18, 0x7E, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
   },
   { 0x00a6,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00, 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
   },
-  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x18, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6, 0x6C, 0x38, 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
+  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6, 0x6C, 0x38, 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
   },
   { 0x00a8,                                     0x00, { 0x00, 0x00, 0x00, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }
   },
@@ -315,7 +315,7 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
   },
   { 0x00d6,                                     0x00, { 0xCC, 0xCC, 0x00, 0x00, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
   },
-  { 0x00d7,                                     0x00, { 0x10, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38, 0x38, 0x6C, 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
+  { 0x00d7,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38, 0x38, 0x6C, 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
   },
   { 0x00d8,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xCE, 0xCE, 0xDE, 0xD6, 0xD6, 0xD6, 0xD6, 0xF6, 0xE6, 0xE6, 0x7C, 0x40, 0x00, 0x00, 0x00 }
   },
@@ -329,11 +329,11 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
   },
   { 0x00dd,                                     0x00, { 0x18, 0x30, 0x00, 0x00, 0x66, 0x66, 0x66, 0x66, 0x66, 0x3C, 0x18, 0x18, 0x18, 0x18, 0x3C, 0x00, 0x00, 0x00, 0x00 }
   },
-  { 0x00de,                                     0x00, { 0x00, 0x00, 0x10, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66, 0x66, 0x66, 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
+  { 0x00de,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66, 0x66, 0x66, 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
   },
   { 0x00df,                                     0x00, { 0x00, 0x00, 0x00, 0x78, 0xCC, 0xCC, 0xCC, 0xCC, 0xD8, 0xCC, 0xC6, 0xC6, 0xC6, 0xC6, 0xCC, 0x00, 0x00, 0x00, 0x00 }
   },
-  { 0x00e0,                                     0x00, { 0x00, 0x30, 0x30, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC, 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
+  { 0x00e0,                                     0x00, { 0x00, 0x00, 0x00, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC, 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
   },
   { 0x00e1,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x30, 0x60, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC, 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
   },
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
  2023-01-07 15:16 [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs Jan Engelhardt
@ 2023-01-07 18:22 ` Michael D Kinney
  2023-01-07 22:41   ` Jan Engelhardt
  2023-01-20 15:57 ` Michael D Kinney
  1 sibling, 1 reply; 6+ messages in thread
From: Michael D Kinney @ 2023-01-07 18:22 UTC (permalink / raw)
  To: devel@edk2.groups.io, jengelh@inai.de; +Cc: Kinney, Michael D

Hi,

Can you add a before and after picture to the PR for the glyphs that have been updated.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jan Engelhardt
> Sent: Saturday, January 7, 2023 7:16 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
> 
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> This was previously posted to https://github.com/tianocore/edk2/pull/3330
> where you can see a visual representation of what is being corrected.
> 
>  .../Universal/Console/GraphicsConsoleDxe/LaffStd.c     | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> index 1f7fe4cda8..99d909592c 100644
> --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> @@ -213,13 +213,13 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00a3,                                     0x00, { 0x00, 0x00, 0x00, 0x38, 0x6C, 0x64, 0x60, 0x60, 0xF0, 0x60, 0x60, 0x60,
> 0x60, 0xE6, 0xFC, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x18, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6,
> 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6,
> 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a5,                                     0x00, { 0x00, 0x00, 0x00, 0x66, 0x66, 0x66, 0x3C, 0x18, 0x7E, 0x18, 0x7E, 0x18,
> 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a6,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00, 0x18, 0x18,
> 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x18, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6, 0x6C, 0x38,
> 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6, 0x6C, 0x38,
> 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a8,                                     0x00, { 0x00, 0x00, 0x00, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> @@ -315,7 +315,7 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00d6,                                     0x00, { 0xCC, 0xCC, 0x00, 0x00, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6,
> 0xC6, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00d7,                                     0x00, { 0x10, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38, 0x38, 0x6C,
> 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00d7,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38, 0x38, 0x6C,
> 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00d8,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xCE, 0xCE, 0xDE, 0xD6, 0xD6, 0xD6, 0xD6, 0xF6,
> 0xE6, 0xE6, 0x7C, 0x40, 0x00, 0x00, 0x00 }
> 
>    },
> 
> @@ -329,11 +329,11 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00dd,                                     0x00, { 0x18, 0x30, 0x00, 0x00, 0x66, 0x66, 0x66, 0x66, 0x66, 0x3C, 0x18, 0x18,
> 0x18, 0x18, 0x3C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00de,                                     0x00, { 0x00, 0x00, 0x10, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66, 0x66, 0x66,
> 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00de,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66, 0x66, 0x66,
> 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00df,                                     0x00, { 0x00, 0x00, 0x00, 0x78, 0xCC, 0xCC, 0xCC, 0xCC, 0xD8, 0xCC, 0xC6, 0xC6,
> 0xC6, 0xC6, 0xCC, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00e0,                                     0x00, { 0x00, 0x30, 0x30, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC,
> 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00e0,                                     0x00, { 0x00, 0x00, 0x00, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC,
> 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00e1,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x30, 0x60, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC,
> 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> --
> 2.39.0
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#98148): https://edk2.groups.io/g/devel/message/98148
> Mute This Topic: https://groups.io/mt/96117470/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
  2023-01-07 18:22 ` [edk2-devel] " Michael D Kinney
@ 2023-01-07 22:41   ` Jan Engelhardt
  0 siblings, 0 replies; 6+ messages in thread
From: Jan Engelhardt @ 2023-01-07 22:41 UTC (permalink / raw)
  To: devel@edk2.groups.io, Kinney, Michael D

On Saturday 2023-01-07 19:22, Michael D Kinney wrote:

>Can you add a before and after picture to the PR for the glyphs that have been updated.

Added to the GH issue.

>> ---
>> This was previously posted to https://github.com/tianocore/edk2/pull/3330
>> where you can see a visual representation of what is being corrected.
>> 
>>  .../Universal/Console/GraphicsConsoleDxe/LaffStd.c     | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
  2023-01-07 15:16 [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs Jan Engelhardt
  2023-01-07 18:22 ` [edk2-devel] " Michael D Kinney
@ 2023-01-20 15:57 ` Michael D Kinney
  2023-01-20 16:26   ` Jan Engelhardt
  1 sibling, 1 reply; 6+ messages in thread
From: Michael D Kinney @ 2023-01-20 15:57 UTC (permalink / raw)
  To: devel@edk2.groups.io, jengelh@inai.de; +Cc: Kinney, Michael D

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jan Engelhardt
> Sent: Saturday, January 7, 2023 7:16 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
> 
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> This was previously posted to https://github.com/tianocore/edk2/pull/3330
> where you can see a visual representation of what is being corrected.
> 
>  .../Universal/Console/GraphicsConsoleDxe/LaffStd.c     | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> index 1f7fe4cda8..99d909592c 100644
> --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> @@ -213,13 +213,13 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00a3,                                     0x00, { 0x00, 0x00, 0x00, 0x38, 0x6C, 0x64, 0x60, 0x60, 0xF0, 0x60,
> 0x60, 0x60, 0x60, 0xE6, 0xFC, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x18, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6,
> 0xC6, 0xC6, 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6,
> 0xC6, 0xC6, 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a5,                                     0x00, { 0x00, 0x00, 0x00, 0x66, 0x66, 0x66, 0x3C, 0x18, 0x7E, 0x18,
> 0x7E, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a6,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00,
> 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x18, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6,
> 0x6C, 0x38, 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6,
> 0x6C, 0x38, 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a8,                                     0x00, { 0x00, 0x00, 0x00, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> @@ -315,7 +315,7 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00d6,                                     0x00, { 0xCC, 0xCC, 0x00, 0x00, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6,
> 0xC6, 0xC6, 0xC6, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00d7,                                     0x00, { 0x10, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38,
> 0x38, 0x6C, 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00d7,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38,
> 0x38, 0x6C, 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00d8,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xCE, 0xCE, 0xDE, 0xD6, 0xD6, 0xD6,
> 0xD6, 0xF6, 0xE6, 0xE6, 0x7C, 0x40, 0x00, 0x00, 0x00 }
> 
>    },
> 
> @@ -329,11 +329,11 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00dd,                                     0x00, { 0x18, 0x30, 0x00, 0x00, 0x66, 0x66, 0x66, 0x66, 0x66, 0x3C,
> 0x18, 0x18, 0x18, 0x18, 0x3C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00de,                                     0x00, { 0x00, 0x00, 0x10, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66,
> 0x66, 0x66, 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00de,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66,
> 0x66, 0x66, 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00df,                                     0x00, { 0x00, 0x00, 0x00, 0x78, 0xCC, 0xCC, 0xCC, 0xCC, 0xD8, 0xCC,
> 0xC6, 0xC6, 0xC6, 0xC6, 0xCC, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00e0,                                     0x00, { 0x00, 0x30, 0x30, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C,
> 0x7C, 0xCC, 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00e0,                                     0x00, { 0x00, 0x00, 0x00, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C,
> 0x7C, 0xCC, 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00e1,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x30, 0x60, 0x00, 0x78, 0x0C, 0x0C,
> 0x7C, 0xCC, 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> --
> 2.39.0
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#98148): https://edk2.groups.io/g/devel/message/98148
> Mute This Topic: https://groups.io/mt/96117470/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
  2023-01-20 15:57 ` Michael D Kinney
@ 2023-01-20 16:26   ` Jan Engelhardt
  2023-01-20 17:43     ` Michael D Kinney
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Engelhardt @ 2023-01-20 16:26 UTC (permalink / raw)
  To: devel@edk2.groups.io, Kinney, Michael D


On Friday 2023-01-20 16:57, Michael D Kinney wrote:
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jan Engelhardt
>> Sent: Saturday, January 7, 2023 7:16 AM
>> To: devel@edk2.groups.io
>> Subject: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
>> 
>> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
>> ---
>> This was previously posted to https://github.com/tianocore/edk2/pull/3330
>> where you can see a visual representation of what is being corrected.
>>
>>  .../Universal/Console/GraphicsConsoleDxe/LaffStd.c     | 10 +++++-----

>Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Speaking of which, what does Laff stand for, anyway?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
  2023-01-20 16:26   ` Jan Engelhardt
@ 2023-01-20 17:43     ` Michael D Kinney
  0 siblings, 0 replies; 6+ messages in thread
From: Michael D Kinney @ 2023-01-20 17:43 UTC (permalink / raw)
  To: Jan Engelhardt, devel@edk2.groups.io; +Cc: Kinney, Michael D

Merged.

PR: https://github.com/tianocore/edk2/pull/3938
Commit: https://github.com/tianocore/edk2/commit/7afef31b2b17d1a8d5248eb562352c6d3505ea14

I do not recall the meaning of LaffStd.  My best guess is that it is Latin Fixed Font Standard.

Mike

> -----Original Message-----
> From: Jan Engelhardt <jengelh@inai.de>
> Sent: Friday, January 20, 2023 8:26 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
> 
> 
> On Friday 2023-01-20 16:57, Michael D Kinney wrote:
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jan Engelhardt
> >> Sent: Saturday, January 7, 2023 7:16 AM
> >> To: devel@edk2.groups.io
> >> Subject: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
> >>
> >> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> >> ---
> >> This was previously posted to https://github.com/tianocore/edk2/pull/3330
> >> where you can see a visual representation of what is being corrected.
> >>
> >>  .../Universal/Console/GraphicsConsoleDxe/LaffStd.c     | 10 +++++-----
> 
> >Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Speaking of which, what does Laff stand for, anyway?

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-01-20 17:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-07 15:16 [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs Jan Engelhardt
2023-01-07 18:22 ` [edk2-devel] " Michael D Kinney
2023-01-07 22:41   ` Jan Engelhardt
2023-01-20 15:57 ` Michael D Kinney
2023-01-20 16:26   ` Jan Engelhardt
2023-01-20 17:43     ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox