public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yuanhao Xie" <yuanhao.xie@intel.com>
To: devel@edk2.groups.io
Subject: [PATCH 0/4] Revert the series of the patches which put APs in
Date: Mon,  9 Jan 2023 11:37:20 +0800	[thread overview]
Message-ID: <20230109033724.1130-1-yuanhao.xie@intel.com> (raw)

This series of original patches requiring revert, redo and further cleanup.

4GB limitation of memory allocation will be kept for the case APs 
still need to be transferred to 32-bit mode before handoff to the OS.

Stack offset for AsmRelocateApLoopStart in 32-bit mode needs to be 
fixed up, as it is calculated taking into account the removed parameters.

The allocation size of the stack should be updated as the variant of 
APs loop function is introduced. 

Keep the logic that removes the XP attribute.

Since the commit 73ccde8f6d04 introduced CpuPageTableLib dependency which 
resolved for OvmfPkg and UefiPayloadPkg, it follows the revert order shown 
as below instead of the reverse order of original commits to ensure the tree 
buildable at every stage of the revert:

73ccde8f6d04 UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS.
3f378450dfaf UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib.
4a8642422460 OvmfPkg: Add CpuPageTableLib required by MpInitLib.
7bda8c648192 UefiCpuPkg: Duplicated AsmRelocateApLoop as AsmRelocateApLoopAmd

Yuanhao Xie (4):
  Revert "UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS."
  Revert "UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib."
  Revert "OvmfPkg: Add CpuPageTableLib required by MpInitLib."
  Revert "UefiCpuPkg: Duplicated AsmRelocateApLoop as
    AsmRelocateApLoopAmd"

 OvmfPkg/AmdSev/AmdSevX64.dsc                  |   3 +-
 OvmfPkg/CloudHv/CloudHvX64.dsc                |   1 -
 OvmfPkg/IntelTdx/IntelTdxX64.dsc              |   4 +-
 OvmfPkg/Microvm/MicrovmX64.dsc                |   3 +-
 OvmfPkg/OvmfPkgIa32X64.dsc                    |   1 -
 OvmfPkg/OvmfPkgX64.dsc                        |   2 -
 OvmfPkg/OvmfXen.dsc                           |   3 +-
 UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |   7 +-
 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       | 128 +++++++------
 .../Library/MpInitLib/Ia32/CreatePageTable.c  |  27 ---
 UefiCpuPkg/Library/MpInitLib/MpEqu.inc        |   2 -
 UefiCpuPkg/Library/MpInitLib/MpLib.h          |  46 +----
 UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm  | 169 -----------------
 .../Library/MpInitLib/X64/CreatePageTable.c   |  75 --------
 UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 176 ++++++++++++++----
 UefiCpuPkg/UefiCpuPkg.dsc                     |   1 -
 UefiPayloadPkg/UefiPayloadPkg.dsc             |   1 -
 17 files changed, 220 insertions(+), 429 deletions(-)
 delete mode 100644 UefiCpuPkg/Library/MpInitLib/Ia32/CreatePageTable.c
 delete mode 100644 UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c

-- 
2.36.1.windows.1


             reply	other threads:[~2023-01-09  3:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09  3:37 Yuanhao Xie [this message]
2023-01-09  3:37 ` [PATCH 1/4] Revert "UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS." Yuanhao Xie
2023-01-09  3:37 ` [PATCH 2/4] Revert "UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib." Yuanhao Xie
2023-01-09  3:48   ` Guo, Gua
2023-01-09  3:37 ` [PATCH 3/4] Revert "OvmfPkg: " Yuanhao Xie
2023-01-09  3:37 ` [PATCH 4/4] Revert "UefiCpuPkg: Duplicated AsmRelocateApLoop as AsmRelocateApLoopAmd" Yuanhao Xie
2023-01-09  8:15 ` [edk2-devel] [PATCH 0/4] Revert the series of the patches which put APs in Laszlo Ersek
2023-01-09 17:54   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109033724.1130-1-yuanhao.xie@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox