public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
@ 2023-01-09 16:42 Moritz Fischer
  2023-01-09 17:02 ` Sami Mujawar
  2023-01-10 15:52 ` Sami Mujawar
  0 siblings, 2 replies; 3+ messages in thread
From: Moritz Fischer @ 2023-01-09 16:42 UTC (permalink / raw)
  To: devel; +Cc: Moritz Fischer, Sami Mujawar

Linux's cpu DT bindings call out arm,armv8 while the code previously
used arm,arm-v8, add second entry to support the arm,arm-v8 case.

Cc: Sami Mujawar <sami.mujawar@arm.com>
Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
Signed-off-by: Moritz Fischer <moritzf@google.com>
---
 DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
index 2c72bd0c58..ee82f7a0b4 100644
--- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
+++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
@@ -23,6 +23,7 @@
 STATIC CONST COMPATIBILITY_STR  CpuCompatibleStr[] = {
   { "arm,arm-v7"     },
   { "arm,arm-v8"     },
+  { "arm,armv8"      },
   { "arm,cortex-a15" },
   { "arm,cortex-a7"  },
   { "arm,cortex-a57" }
-- 
2.39.0.314.g84b9a713c41-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
  2023-01-09 16:42 [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string Moritz Fischer
@ 2023-01-09 17:02 ` Sami Mujawar
  2023-01-10 15:52 ` Sami Mujawar
  1 sibling, 0 replies; 3+ messages in thread
From: Sami Mujawar @ 2023-01-09 17:02 UTC (permalink / raw)
  To: Moritz Fischer, devel; +Cc: nd@arm.com, Pierre Gondois, Ard Biesheuvel

Hi Morit,

Thank you for this patch.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 09/01/2023 04:42 pm, Moritz Fischer wrote:
> Linux's cpu DT bindings call out arm,armv8 while the code previously
> used arm,arm-v8, add second entry to support the arm,arm-v8 case.
>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
> Signed-off-by: Moritz Fischer <moritzf@google.com>
> ---
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> index 2c72bd0c58..ee82f7a0b4 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> @@ -23,6 +23,7 @@
>   STATIC CONST COMPATIBILITY_STR  CpuCompatibleStr[] = {
>     { "arm,arm-v7"     },
>     { "arm,arm-v8"     },
> +  { "arm,armv8"      },
>     { "arm,cortex-a15" },
>     { "arm,cortex-a7"  },
>     { "arm,cortex-a57" }

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
  2023-01-09 16:42 [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string Moritz Fischer
  2023-01-09 17:02 ` Sami Mujawar
@ 2023-01-10 15:52 ` Sami Mujawar
  1 sibling, 0 replies; 3+ messages in thread
From: Sami Mujawar @ 2023-01-10 15:52 UTC (permalink / raw)
  To: Moritz Fischer, devel@edk2.groups.io; +Cc: nd

Hi Moritz,

I have merged this patch with a minor change to the commit message.

Merged as 82dd766f2522..717f35a9f2d8

Thanks.

Regards,

Sami Mujawar

On 09/01/2023, 16:42, "Moritz Fischer" <moritzf@google.com> wrote:

    Linux's cpu DT bindings call out arm,armv8 while the code previously
    used arm,arm-v8, add second entry to support the arm,arm-v8 case.

    Cc: Sami Mujawar <sami.mujawar@arm.com>
    Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
    Signed-off-by: Moritz Fischer <moritzf@google.com>
    ---
     DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 +
     1 file changed, 1 insertion(+)

    diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
    index 2c72bd0c58..ee82f7a0b4 100644
    --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
    +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
    @@ -23,6 +23,7 @@
     STATIC CONST COMPATIBILITY_STR  CpuCompatibleStr[] = {
       { "arm,arm-v7"     },
       { "arm,arm-v8"     },
    +  { "arm,armv8"      },
       { "arm,cortex-a15" },
       { "arm,cortex-a7"  },
       { "arm,cortex-a57" }
    -- 
    2.39.0.314.g84b9a713c41-goog



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-10 15:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-09 16:42 [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string Moritz Fischer
2023-01-09 17:02 ` Sami Mujawar
2023-01-10 15:52 ` Sami Mujawar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox