public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: devel@edk2.groups.io
Cc: Min Xu <min.m.xu@intel.com>, Laszlo Ersek <lersek@redhat.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>
Subject: [PATCH V3 0/6] Refactor installation of gQemuAcpiTableNotifyProtocol
Date: Wed, 11 Jan 2023 09:22:29 +0800	[thread overview]
Message-ID: <20230111012235.189-1-min.m.xu@intel.com> (raw)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237

Commit 9fdc70af6ba8 breaks log analysis and code cohesion in 
AcpiPlatformDxe. See the detailed information in BZ#4237.

This patch-set contains below patches to fix above issues.
#1: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL and delete
    QemuAcpiTableNotify.h.
#2: Use local variable of ChAcpiHandle to store the handle.
#3: Use local variable of QemuAcpiHandle to store the handle.
#4: Add log to show how many ACPI tables installed.
#5: Refactor the installation of QemuAcpiTableNotifyProtocol and
    its error handling.
#6: Return error code if QemuAcpiTableNotifyProtocol is failed to be
    installed so that the caller can handle the error.

Code: https://github.com/mxu9/edk2/tree/AcpiPlatformDxe.v3

v3 changes:
 - Set QemuAcpiHandle to NULL right before installing the
   gQemuAcpiTableNotifyProtocol.

v2 changes:
 - Split v1 patch into 6 separate patches.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>

Min M Xu (6):
  OvmfPkg/AcpiPlatformDxe: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL
  OvmfPkg/AcpiPlatformDxe: Use local variable in CloudHvAcpi.c
  OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c
  OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables
  OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol
  OvmfPkg/AcpiPlatformDxe: Return error if installing NotifyProtocol
    failed

 OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c         | 23 +++++-----
 OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c       | 43 ++++++++++++-------
 .../Include/Protocol/QemuAcpiTableNotify.h    | 27 ------------
 3 files changed, 40 insertions(+), 53 deletions(-)
 delete mode 100644 OvmfPkg/Include/Protocol/QemuAcpiTableNotify.h

-- 
2.29.2.windows.2


             reply	other threads:[~2023-01-11  1:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11  1:22 Min Xu [this message]
2023-01-11  1:22 ` [PATCH V3 1/6] OvmfPkg/AcpiPlatformDxe: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL Min Xu
2023-01-12 10:03   ` Boeuf, Sebastien
2023-01-11  1:22 ` [PATCH V3 2/6] OvmfPkg/AcpiPlatformDxe: Use local variable in CloudHvAcpi.c Min Xu
2023-01-12 10:04   ` Boeuf, Sebastien
2023-01-11  1:22 ` [PATCH V3 3/6] OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c Min Xu
2023-01-11 16:49   ` [edk2-devel] " Laszlo Ersek
2023-01-11  1:22 ` [PATCH V3 4/6] OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables Min Xu
2023-01-11  1:22 ` [PATCH V3 5/6] OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol Min Xu
2023-01-11 16:53   ` [edk2-devel] " Laszlo Ersek
2023-01-11  1:22 ` [PATCH V3 6/6] OvmfPkg/AcpiPlatformDxe: Return error if installing NotifyProtocol failed Min Xu
2023-01-12 10:04   ` Boeuf, Sebastien
2023-01-15 11:50 ` [edk2-devel] [PATCH V3 0/6] Refactor installation of gQemuAcpiTableNotifyProtocol Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111012235.189-1-min.m.xu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox