From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.12270.1673400253669081955 for ; Tue, 10 Jan 2023 17:24:13 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=d7qD5RFP; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673400253; x=1704936253; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kED0TI1oTpYlRwuspjfVTRBwBU3J+LqneTUDDo06bRY=; b=d7qD5RFPXZcZf+F+X3yHuX/dIpjTbkfjIkm2saPrX5uuBkLH3BEjOegx pzj5OHhMjY9tkK8oGaSEaEVg82YBvTMtyfLx/xdkQq/dvvvnSEnCWfpJ/ t03SCE1scsH1TlJUTafAYya6BT6VgyENimVBUfkk3C4NUi2urnOAzMU3a /PCGxEwIeXG2rCZ9KxBW6Z8WO/mfPzZFO2d8S6yiMYrrOQpErtrVTs+EB gPPXF6KvW1IUg64rD5XFKGlhQIOSoKus9x0LGMtI7mepFOzZ57yY4R6Qp viTSnmiQBFdWXFrIp51j6Zz+fCsCjdw2hz05fFw3uXSum/rcB2oTaI8Mg g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="387764414" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="387764414" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:24:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="659192805" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="659192805" Received: from mxu9-mobl1.ccr.corp.intel.com ([10.213.42.137]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:24:03 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min M Xu , Laszlo Ersek , Erdem Aktas , James Bottomley , Jiewen Yao , Gerd Hoffmann , Tom Lendacky Subject: [PATCH V3 3/6] OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c Date: Wed, 11 Jan 2023 09:22:32 +0800 Message-Id: <20230111012235.189-4-min.m.xu@intel.com> X-Mailer: git-send-email 2.29.2.windows.2 In-Reply-To: <20230111012235.189-1-min.m.xu@intel.com> References: <20230111012235.189-1-min.m.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 The handle of mQemuAcpiHandle is not needed for anything, beyond the scope of the InstallQemuFwCfgTables(). So a local variable will suffice for storing the handle. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Reported-by: Laszlo Ersek Reviewed-by: Laszlo Ersek Signed-off-by: Min Xu --- OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c index 1a3852904df9..9711335c6cac 100644 --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c @@ -20,7 +20,6 @@ #include // gBS #include "AcpiPlatform.h" -EFI_HANDLE mQemuAcpiHandle = NULL; // // The user structure for the ordered collection that will track the fw_cfg @@ -1101,6 +1100,7 @@ InstallQemuFwCfgTables ( ORDERED_COLLECTION_ENTRY *TrackerEntry, *TrackerEntry2; ORDERED_COLLECTION *SeenPointers; ORDERED_COLLECTION_ENTRY *SeenPointerEntry, *SeenPointerEntry2; + EFI_HANDLE QemuAcpiHandle; Status = QemuFwCfgFindFile ("etc/table-loader", &FwCfgItem, &FwCfgSize); if (EFI_ERROR (Status)) { @@ -1278,8 +1278,9 @@ UninstallAcpiTables: // Install a protocol to notify that the ACPI table provided by Qemu is // ready. // + QemuAcpiHandle = NULL; gBS->InstallProtocolInterface ( - &mQemuAcpiHandle, + &QemuAcpiHandle, &gQemuAcpiTableNotifyProtocolGuid, EFI_NATIVE_INTERFACE, NULL -- 2.29.2.windows.2