From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.12263.1673400289090483968 for ; Tue, 10 Jan 2023 17:24:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=LOWfEsoE; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673400291; x=1704936291; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e4Zw/ZVtnO17/pHNfKaknmLNn46TgSmqoQkNoTzQyzo=; b=LOWfEsoEiNDmWm1RYaf2XnIO2rjaurO5n4VrUsC/dSeO/tBG9Mg3/XJH ENy20MNf4wWO0cIN9SdLKlztjOROskHBaQ4i+VK0Unyb+OCsyvKH1TSc6 VrqiE+3HLU6FbrtaJ6qnPgnXJwvC9WZpNNhJQh9EIzZ2btJdtXoa/dybf lBKrDVpXPjBKHFhLApdLDLiAX+0mKGpfleyOlWjICg1aVtIcG8wvUFeZD 7DHc90c3ydUCYYReHb5tOfPGlrkOdd9I3/9et+7ktxcdGg6ujaWcUW8Ov Stm+9qe1zu/OakOkMDbRfW9mDOOgDHJOkCwXP8PDaWLBwaVYK+X+CZiZD Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="387764545" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="387764545" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:24:38 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="659192889" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="659192889" Received: from mxu9-mobl1.ccr.corp.intel.com ([10.213.42.137]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:24:28 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min M Xu , Erdem Aktas , James Bottomley , Jiewen Yao , Gerd Hoffmann , Tom Lendacky , Sebastien Boeuf Subject: [PATCH V3 6/6] OvmfPkg/AcpiPlatformDxe: Return error if installing NotifyProtocol failed Date: Wed, 11 Jan 2023 09:22:35 +0800 Message-Id: <20230111012235.189-7-min.m.xu@intel.com> X-Mailer: git-send-email 2.29.2.windows.2 In-Reply-To: <20230111012235.189-1-min.m.xu@intel.com> References: <20230111012235.189-1-min.m.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Installation of gQemuAcpiTableNotifyProtocol may fail. The error code should be returned so that the caller can handle it. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Cc: Sebastien Boeuf Signed-off-by: Min Xu --- OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c b/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c index 8f90ea23996d..d56eb074a987 100644 --- a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c +++ b/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c @@ -89,12 +89,16 @@ InstallCloudHvTablesTdx ( // ready. // ChAcpiHandle = NULL; - gBS->InstallProtocolInterface ( - &ChAcpiHandle, - &gQemuAcpiTableNotifyProtocolGuid, - EFI_NATIVE_INTERFACE, - NULL - ); + Status = gBS->InstallProtocolInterface ( + &ChAcpiHandle, + &gQemuAcpiTableNotifyProtocolGuid, + EFI_NATIVE_INTERFACE, + NULL + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + return Status; + } return EFI_SUCCESS; } -- 2.29.2.windows.2