public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, jiaxin.wu@intel.com
Subject: Re: [edk2-devel] [PATCH v1 0/4] Support SMM Relocated SmBase handling
Date: Fri, 13 Jan 2023 10:49:54 +0100	[thread overview]
Message-ID: <20230113094954.lc73fbwz67mrfbve@sirius.home.kraxel.org> (raw)
In-Reply-To: <20230113071738.15868-1-jiaxin.wu@intel.com>

On Fri, Jan 13, 2023 at 03:17:34PM +0800, Wu, Jiaxin wrote:
> Below serial patches are to support the SMM Relocated SmBase handling.
> To achieve, new hob interface is procuded, and will be consumed by SMM
> CPU driver & SmmCpuFeaturesLib to do SmBase initialization:

Who produces that HOB?  I see only consumers in this patch series.

The patch series doesn't even pass BaseTools/Scripts/PatchCheck.py,
it will surely not pass CI.

> With SMM Base Hob, SMM CPU driver does not need the RSM instruction
> to reload the SMBASE register with the new allocated value in SMBASE
> field each time it exits SMM. SMBASE Register for each processors
> have already been programmed in parallel since the same default
> SMBASE Address(0x30000) is not used, thus the CPUs over-writing
> each other's SMM Save State Area will not happen.

Care to explain how this works?  SMBASE setup has to happen somewhere
(probably in the HOB producer), how does that work without using the
default smbase address?

take care,
  Gerd


  parent reply	other threads:[~2023-01-13  9:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  7:17 [PATCH v1 0/4] Support SMM Relocated SmBase handling Wu, Jiaxin
2023-01-13  7:17 ` [PATCH v1 1/4] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Wu, Jiaxin
2023-01-13  7:17 ` [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Wu, Jiaxin
2023-01-13  9:51   ` Gerd Hoffmann
2023-01-13 10:10     ` Wu, Jiaxin
2023-01-13  7:17 ` [PATCH v1 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE Wu, Jiaxin
2023-01-13  7:17 ` [PATCH v1 4/4] OvmfPkg/SmmCpuFeaturesLib: " Wu, Jiaxin
2023-01-13  9:49 ` Gerd Hoffmann [this message]
2023-01-13 10:18   ` [edk2-devel] [PATCH v1 0/4] Support SMM Relocated SmBase handling Wu, Jiaxin
2023-01-13 12:38     ` Gerd Hoffmann
2023-01-13 12:47       ` Wu, Jiaxin
2023-01-16  7:50         ` Gerd Hoffmann
2023-01-13 10:22   ` Wu, Jiaxin
2023-01-13 12:45 ` Gerd Hoffmann
2023-01-13 12:51   ` Wu, Jiaxin
2023-01-13 15:37   ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113094954.lc73fbwz67mrfbve@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox