From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.82521.1673603399193026191
 for <devel@edk2.groups.io>;
 Fri, 13 Jan 2023 01:49:59 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RhPer3U9;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1673603398;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=PTAi46Jo8LYoyJmk+/zb6RabgF5uHj9LdHQPnGzaqRQ=;
	b=RhPer3U9YbAqhLYw6SvS9Lo8fW3LDVH3rMOe5KLqXkdM+JrmWnxt4X6CXX9RQQW8vMM/YP
	aY09uIYJMh9Re3N66ft2d6DoEr8sA2oNOnT6ZY6ZC+HLV6Sg8aE79r8kIB5tAzYqx1hr3P
	QutVdy6LE5f0YN47jyqccwZfuLCFPrs=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-204-rZbvywqnNsWOATLPOJeNlw-1; Fri, 13 Jan 2023 04:49:56 -0500
X-MC-Unique: rZbvywqnNsWOATLPOJeNlw-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47833101A5BA;
	Fri, 13 Jan 2023 09:49:56 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.238])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 1CDA814171B8;
	Fri, 13 Jan 2023 09:49:56 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id D4AAC1800606; Fri, 13 Jan 2023 10:49:54 +0100 (CET)
Date: Fri, 13 Jan 2023 10:49:54 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, jiaxin.wu@intel.com
Subject: Re: [edk2-devel] [PATCH v1 0/4] Support SMM Relocated SmBase handling
Message-ID: <20230113094954.lc73fbwz67mrfbve@sirius.home.kraxel.org>
References: <20230113071738.15868-1-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230113071738.15868-1-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 13, 2023 at 03:17:34PM +0800, Wu, Jiaxin wrote:
> Below serial patches are to support the SMM Relocated SmBase handling.
> To achieve, new hob interface is procuded, and will be consumed by SMM
> CPU driver & SmmCpuFeaturesLib to do SmBase initialization:

Who produces that HOB?  I see only consumers in this patch series.

The patch series doesn't even pass BaseTools/Scripts/PatchCheck.py,
it will surely not pass CI.

> With SMM Base Hob, SMM CPU driver does not need the RSM instruction
> to reload the SMBASE register with the new allocated value in SMBASE
> field each time it exits SMM. SMBASE Register for each processors
> have already been programmed in parallel since the same default
> SMBASE Address(0x30000) is not used, thus the CPUs over-writing
> each other's SMM Save State Area will not happen.

Care to explain how this works?  SMBASE setup has to happen somewhere
(probably in the HOB producer), how does that work without using the
default smbase address?

take care,
  Gerd