From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.85244.1673613502762473294 for ; Fri, 13 Jan 2023 04:38:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XmWn29CG; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673613501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lprCYwWjuGv74ctdrj42QXXRaY7mvkSa+DyRVBkZ1Yg=; b=XmWn29CGLPJGuBm4vvtMTqSm07zMX0V/o+ZQGVJPYLQrZZ2152TwuibBnUpvxDwLcO+CWm CctCL2MnFz2bifn9iibiz7D4fc89s6b/m3cCjzPDXzoO8BT799FUPse6gtN8SKadVKHB+x IterjoDiSl242Q6d96XWRxQnDHDXGig= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-vDVN0YojPeqbfJeqO1kgqw-1; Fri, 13 Jan 2023 07:38:18 -0500 X-MC-Unique: vDVN0YojPeqbfJeqO1kgqw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D2EB80234E; Fri, 13 Jan 2023 12:38:18 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D128F1121314; Fri, 13 Jan 2023 12:38:17 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 78DEB1800620; Fri, 13 Jan 2023 13:38:16 +0100 (CET) Date: Fri, 13 Jan 2023 13:38:16 +0100 From: "Gerd Hoffmann" To: "Wu, Jiaxin" Cc: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v1 0/4] Support SMM Relocated SmBase handling Message-ID: <20230113123816.tspo26bx4he67nnt@sirius.home.kraxel.org> References: <20230113071738.15868-1-jiaxin.wu@intel.com> <20230113094954.lc73fbwz67mrfbve@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 13, 2023 at 10:18:59AM +0000, Wu, Jiaxin wrote: > Thanks Comments Gerd, I will resolve the CI check issue (I have noticed that in https://github.com/tianocore/edk2/pull/3884) & refine the usage description in next version. > > Anyway, Ray also helped explain the usage as below, I will integrate it in the hob definition .h file, help below can help understand the design.: > > The default SMBASE for the x86 processor is 0x30000. When SMI happens, CPU runs the > SMI handler at SMBASE+0x8000. Also, the SMM save state area is within SMBASE+0x10000. > > One of the SMM initialization from CPU perspective is to program the new SMBASE (in TSEG range) > for each CPU thread. When the SMBASE update happens in a PEI module, the PEI module shall > produce the SMM_BASE_HOB in HOB database which tells the PiSmmCpuDxeSmm driver which runs > at a later phase about the new SMBASE for each CPU thread. There are no PEI module changes in this patch series. So where does the HOB come from? And what are the reasons for setting SMBASE in a PEI module instead of PiSmmCpuDxeSmm? take care, Gerd