From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.161630.1673855462125401162 for ; Sun, 15 Jan 2023 23:51:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=esAp2/D0; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673855461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zz65GZCuGuCD7whT2xoLSCmx620/gdC9Gi+JexhTq7s=; b=esAp2/D0/XFdgzwO5kR7KaWPydORIr+mDSy3e+0M6MnAi0M45Qxu+s5hvDeFcn1DRakWu1 pW/e/59jlI/OOwHfTzVOCadh/sb/H25i8QEvvL7BX7YsHZwMW8wrqs4hWzQfnlC0NW3BIw ngi8GBgYvMufHZLZ14jKKD/vBLJSYUg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-9Xb9OwTXMI6m0g_L9y72Jg-1; Mon, 16 Jan 2023 02:50:57 -0500 X-MC-Unique: 9Xb9OwTXMI6m0g_L9y72Jg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CEE4129AB3FE; Mon, 16 Jan 2023 07:50:56 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90ECA492B10; Mon, 16 Jan 2023 07:50:56 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 37A6F18017F5; Mon, 16 Jan 2023 08:50:55 +0100 (CET) Date: Mon, 16 Jan 2023 08:50:55 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, jiaxin.wu@intel.com Subject: Re: [edk2-devel] [PATCH v1 0/4] Support SMM Relocated SmBase handling Message-ID: <20230116075055.crnjseufoauzcfuy@sirius.home.kraxel.org> References: <20230113071738.15868-1-jiaxin.wu@intel.com> <20230113094954.lc73fbwz67mrfbve@sirius.home.kraxel.org> <20230113123816.tspo26bx4he67nnt@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 13, 2023 at 12:47:54PM +0000, Wu, Jiaxin wrote: > > > > There are no PEI module changes in this patch series. > > > > So where does the HOB come from? > > Who use, who produce. Here, just provide the interface capability. Well, yes. This series adds the interface (i.e. the HOB guid and struct). It also updates some modules which consume that new interface. It does *not* add a producer of that new interface. > > And what are the reasons for setting SMBASE in a PEI module instead > > of PiSmmCpuDxeSmm? > > Do the smbase relocated ahead of SMM cpu driver can bring the benefit > as I explain in the patch 2: > PiSmmCpuDxeSmm will retrieve the SMBASE addresses from SMM Base Hob > and installs the SMI handler at [SMBASE+8000h] for each processor > instead of relocating SMM Base addresses from SMRAM again. That doesn't answer my question. Sure, if you do the SMM Base relocation somewhere else PiSmmCpuDxeSmm shouldn't do it again. It is not clear why you do the SMM Base relocation somewhere else. The code for that is also not present in this patch series. take care, Gerd