From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.161851.1673856732291515935
 for <devel@edk2.groups.io>;
 Mon, 16 Jan 2023 00:12:12 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hk2X65A8;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1673856730;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7nxlGfgZfsX5oO39BHAfnFR7rh5piOjdEFaP+lVLZiQ=;
	b=hk2X65A8wS7SzFjuHOAtUA5yB/0FpRVgln/9FAJDsrTbopCsZjFmgp6qDSmO/IlU8iRD/G
	ZGTW6N6qv2rAMQsRMPC2FmzsEYL1Cjjj8KP2yGfDhAWXtRZ/LeoEFRdpIm+CaILHx2B0Q/
	oG9h3kwu1rEsFxoslH8b0l1NBZb3TNg=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-492-aG5pX-EoMF-zASi-Nebnzw-1; Mon, 16 Jan 2023 03:12:04 -0500
X-MC-Unique: aG5pX-EoMF-zASi-Nebnzw-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B88B80D0EC;
	Mon, 16 Jan 2023 08:12:04 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.124])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A6C81121314;
	Mon, 16 Jan 2023 08:12:04 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 807E518017F5; Mon, 16 Jan 2023 09:12:02 +0100 (CET)
Date: Mon, 16 Jan 2023 09:12:02 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v2 4/4] OvmfPkg/SmmCpuFeaturesLib: Skip to configure SMBASE
Message-ID: <20230116081202.xpfsbx4yyubr4opn@sirius.home.kraxel.org>
References: <20230113153045.13060-1-jiaxin.wu@intel.com>
 <20230113153045.13060-5-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230113153045.13060-5-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 13, 2023 at 11:30:45PM +0800, Jiaxin Wu wrote:
> This patch is to avoid configure SMBASE if SmBase relocation has been
> done. If gSmmBaseHobGuid found, means SmBase info has been relocated
> and recorded in the SmBase array. No need to do the relocation in
> SmmCpuFeaturesInitializeProcessor().

You will not find a gSmmBaseHobGuid HOB if you don't produce it
somewhere.

take care,
  Gerd