From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.163612.1673865566419985836
 for <devel@edk2.groups.io>;
 Mon, 16 Jan 2023 02:39:26 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hMb5r6Ed;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1673865565;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=W9zd0VWSnHpJCQdsD/0TL1e7aETdo2h459sxCqNqtGU=;
	b=hMb5r6EdXylwy0/QioTdYUCCQ9SNDLBr7EK6ByXzVNE5m8hwIIo0v2BlwGg4B1YANsnXe7
	C3GjZU/zrZbYf8TxXI/UoFyLzfU+TsLm8IDWxEziDpZ9VdB5Iqc63F1DKhLlYGTXIEPubV
	7f9cOb+tJ4cHLtj5l5Ek+Qn/SGTY8Qk=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-437-LopW0CLIN_K-huwQyRTaNQ-1; Mon, 16 Jan 2023 05:39:22 -0500
X-MC-Unique: LopW0CLIN_K-huwQyRTaNQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 69D4B1C068DB;
	Mon, 16 Jan 2023 10:39:21 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.124])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id ED91239D6D;
	Mon, 16 Jan 2023 10:39:20 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7E28D18017F5; Mon, 16 Jan 2023 11:39:19 +0100 (CET)
Date: Mon, 16 Jan 2023 11:39:19 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, pedro.falcato@gmail.com
Cc: lisik@google.com, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>, michael.roth@amd.com
Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Create additional PML4 entries for large SEV-SNP VMs
Message-ID: <20230116103919.ff73h2lotmovl77u@sirius.home.kraxel.org>
References: <5e1916c6669ee2a918a2c22b7698e96f7dbf5488.1673568149.git.lisik@google.com>
 <CAKbZUD3z82Z4nP2PmfS-ED=_0UpGTRCnh4b7vw+RrRVKGCziTQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKbZUD3z82Z4nP2PmfS-ED=_0UpGTRCnh4b7vw+RrRVKGCziTQ@mail.gmail.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> (now that I check, all of this insane behavior seems to have been
> inherited from MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c. Sorry
> for the rant.)

We have UefiCpuPkg/Library/CpuPageTableLib meanwhile.

So switch the code over to use that instead, and reduce the number
of VirtualMemory.c copies floating around in the tree?

take care,
  Gerd