From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.193785.1673954900316463853 for ; Tue, 17 Jan 2023 03:28:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CpOkU0j+; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673954899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G46b4rjwCx2Lb8rVhYeFMz6cyqMmPPU8cy+ThEPpg9A=; b=CpOkU0j+7QyrC583/4hP3yyR9ruoE/lZrnLtD17CWnAehAGFEcDy9RRObynxk+Iwb2HAOi KJW5et1x5rseVdTg67HM1eWEeLTUNAvqRgSKW+AIy6B0JA3lrc9Qt4ew8IDbFfY1li6zTH hV/QDk3NmYQ8MiGbXADdJwlalxqpgmU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-171-A-teKNV6OGOvVBB0XBSbwQ-1; Tue, 17 Jan 2023 06:28:16 -0500 X-MC-Unique: A-teKNV6OGOvVBB0XBSbwQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0560D1C0878F; Tue, 17 Jan 2023 11:28:16 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE71A40C2064; Tue, 17 Jan 2023 11:28:15 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0CC261800097; Tue, 17 Jan 2023 12:28:14 +0100 (CET) Date: Tue, 17 Jan 2023 12:28:14 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Michael Roth Subject: Re: [PATCH V1 5/7] OvmfPkg: Enable Tdx measurement in OvmfPkgX64 Message-ID: <20230117112814.p6mkwppgcv57xsmy@sirius.home.kraxel.org> References: <20230117074016.1056-1-min.m.xu@intel.com> <20230117074016.1056-6-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <20230117074016.1056-6-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 17, 2023 at 03:40:14PM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 > > This patch enables Tdx measurement in OvmfPkgX64 with below changes: > 1) TDX_ENABLE is introduced in OvmfPkgX64.dsc. This flag indicates > if Intel TDX is enabled in OvmfPkgX64. Its default value is FALSE. > 2) Update SecMain.c with the functions provided by TdxHelperLib > 3) Include TdTcg2Dxe in OvmfPkgX64 so that CC_MEASUREMENT_PROTOCOL > is installed in a Td-guest. TdTcg2Dxe is controlled by TDX_ENABLE > because it is only valid when Intel TDX is enabled. > 3) OvmfTpmLibs.dsc.inc and OvmfTpmSecurityStub.dsc.inc are updated > because DxeTpm2MeasureBootLib.inf and DxeTpmMeasurementLib.inf > should be included to support CC_MEASUREMENT_PROTOCOL. Acked-by: Gerd Hoffmann