Re: [PATCH V3 0/2] [PATCH V1 0/2] Refactor TDX MmioExit

["Gerd Hoffmann" <kraxel@redhat.com>]

On Tue, Jan 17, 2023 at 03:43:28PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4169
> 
> The previous TDX MmioExit doesn't handle the Mmio instructions correctly
> in some scenarios. This patch-set refactors the implementation to fix the
> issues.
> 
> Before the refactoring, common X86 instruction codes in CcExitVcHandler.c
> are moved to separate files (CcInstruction.h / CcInstruction.c) so that
> these codes can be re-used in TDX.
> 
> Code: https://github.com/mxu9/edk2/tree/TdxMmioExit.v3
> 
> v3 changes:
>  - Handle the error if an error is returned from TdxMmioReadWrite.
>  - Add more check in ParseMmioExitInstructions.
> 
> v2 changes:
>  - Add CpuDeadLoop () after each TDVMCALL(HALT) in VE handler. Because
>    TDVMCALL(HALT) is not trusted.
>  - Other minor changes such as deleting ASSERT in VE handler. Because
>    any error in VE handler will trigger CpuDeadLoop (). So ASSERT is not
>    needed any more.

Series:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>