* [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit
@ 2023-01-17 23:53 Min Xu
2023-01-18 0:15 ` Yao, Jiewen
[not found] ` <173B3EFD07CF1467.24231@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Min Xu @ 2023-01-17 23:53 UTC (permalink / raw)
To: devel
Cc: Min M Xu, Erdem Aktas, James Bottomley, Jiewen Yao, Gerd Hoffmann,
Tom Lendacky, Michael Roth
From: Min M Xu <min.m.xu@intel.com>
Status should be initialized otherwise it may return unexpected value.
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Michael Roth <michael.roth@amd.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>
---
OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
index 30d547d5fe55..872f772a5ac8 100644
--- a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
+++ b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
@@ -105,10 +105,11 @@ IoExit (
UINT64 RepCnt;
UINT64 Status;
- Val = 0;
- Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
- Size = Veinfo->ExitQualification.Io.Size + 1;
- Port = Veinfo->ExitQualification.Io.Port;
+ Val = 0;
+ Status = 0;
+ Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
+ Size = Veinfo->ExitQualification.Io.Size + 1;
+ Port = Veinfo->ExitQualification.Io.Port;
if (Veinfo->ExitQualification.Io.String) {
//
--
2.29.2.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit
2023-01-17 23:53 [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit Min Xu
@ 2023-01-18 0:15 ` Yao, Jiewen
[not found] ` <173B3EFD07CF1467.24231@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2023-01-18 0:15 UTC (permalink / raw)
To: Xu, Min M, devel@edk2.groups.io
Cc: Aktas, Erdem, James Bottomley, Gerd Hoffmann, Tom Lendacky,
Michael Roth
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Wednesday, January 18, 2023 7:53 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Aktas, Erdem
> <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Tom Lendacky <thomas.lendacky@amd.com>; Michael Roth
> <michael.roth@amd.com>
> Subject: [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit
>
> From: Min M Xu <min.m.xu@intel.com>
>
> Status should be initialized otherwise it may return unexpected value.
>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> ---
> OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> index 30d547d5fe55..872f772a5ac8 100644
> --- a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> +++ b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> @@ -105,10 +105,11 @@ IoExit (
> UINT64 RepCnt;
> UINT64 Status;
>
> - Val = 0;
> - Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
> - Size = Veinfo->ExitQualification.Io.Size + 1;
> - Port = Veinfo->ExitQualification.Io.Port;
> + Val = 0;
> + Status = 0;
> + Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
> + Size = Veinfo->ExitQualification.Io.Size + 1;
> + Port = Veinfo->ExitQualification.Io.Port;
>
> if (Veinfo->ExitQualification.Io.String) {
> //
> --
> 2.29.2.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit
[not found] ` <173B3EFD07CF1467.24231@groups.io>
@ 2023-01-18 6:22 ` Yao, Jiewen
0 siblings, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2023-01-18 6:22 UTC (permalink / raw)
To: devel@edk2.groups.io, Yao, Jiewen, Xu, Min M
Cc: Aktas, Erdem, James Bottomley, Gerd Hoffmann, Tom Lendacky,
Michael Roth
Merged https://github.com/tianocore/edk2/pull/3922
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, January 18, 2023 8:16 AM
> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
> Cc: Aktas, Erdem <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>; Gerd Hoffmann <kraxel@redhat.com>; Tom
> Lendacky <thomas.lendacky@amd.com>; Michael Roth
> <michael.roth@amd.com>
> Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status
> in IoExit
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: Xu, Min M <min.m.xu@intel.com>
> > Sent: Wednesday, January 18, 2023 7:53 AM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m.xu@intel.com>; Aktas, Erdem
> > <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Yao,
> > Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> > Tom Lendacky <thomas.lendacky@amd.com>; Michael Roth
> > <michael.roth@amd.com>
> > Subject: [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit
> >
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > Status should be initialized otherwise it may return unexpected value.
> >
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Michael Roth <michael.roth@amd.com>
> > Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> > ---
> > OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > index 30d547d5fe55..872f772a5ac8 100644
> > --- a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > +++ b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > @@ -105,10 +105,11 @@ IoExit (
> > UINT64 RepCnt;
> > UINT64 Status;
> >
> > - Val = 0;
> > - Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
> > - Size = Veinfo->ExitQualification.Io.Size + 1;
> > - Port = Veinfo->ExitQualification.Io.Port;
> > + Val = 0;
> > + Status = 0;
> > + Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
> > + Size = Veinfo->ExitQualification.Io.Size + 1;
> > + Port = Veinfo->ExitQualification.Io.Port;
> >
> > if (Veinfo->ExitQualification.Io.String) {
> > //
> > --
> > 2.29.2.windows.2
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-18 6:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-17 23:53 [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit Min Xu
2023-01-18 0:15 ` Yao, Jiewen
[not found] ` <173B3EFD07CF1467.24231@groups.io>
2023-01-18 6:22 ` [edk2-devel] " Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox