From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 3/4] OvmfPkg/IntelTdx: Enable separate-fv in IntelTdx/IntelTdxX64.fdf
Date: Wed, 18 Jan 2023 08:54:13 +0100 [thread overview]
Message-ID: <20230118075413.5ivehlk34ho3n6va@sirius.home.kraxel.org> (raw)
In-Reply-To: <PH0PR11MB50649497F7FF3CD65B60F351C5C69@PH0PR11MB5064.namprd11.prod.outlook.com>
On Tue, Jan 17, 2023 at 01:07:53PM +0000, Xu, Min M wrote:
> On January 17, 2023 6:57 PM, Gerd Hoffmann wrote:
> >
> > > -INF
> > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDx
> > e.inf
> >
> > If you move the gfx console driver you can move the gfx hardware drivers
> > too:
> >
> > OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
> > OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf
> > OvmfPkg/VirtioGpuDxe/VirtioGpu.inf
> >
> Do you mean these 3 gfx hardware drivers should be in NCCFV as GraphicsConsoleDxe is? They're are all in NCCFV.
> https://github.com/mxu9/edk2/blob/Separate-Fv.v3/OvmfPkg/IntelTdx/IntelTdxX64.fdf#L298
> https://github.com/mxu9/edk2/blob/Separate-Fv.v3/OvmfPkg/IntelTdx/IntelTdxX64.fdf#L330-L333
Good. I missed them being moved down, but sees this was not needed in
the first place ;)
take care,
Gerd
next prev parent reply other threads:[~2023-01-18 7:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 23:31 [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx Min Xu
2023-01-16 23:31 ` [PATCH V3 1/4] EmbeddedPkg/PrePiLib: Add FFS_CHECK_SECTION_HOOK when finding section Min Xu
2023-01-16 23:31 ` [PATCH V3 2/4] OvmfPkg: Add PCDs/GUID for NCCFV Min Xu
2023-01-16 23:31 ` [PATCH V3 3/4] OvmfPkg/IntelTdx: Enable separate-fv in IntelTdx/IntelTdxX64.fdf Min Xu
2023-01-17 10:56 ` Gerd Hoffmann
2023-01-17 13:07 ` Min Xu
2023-01-18 7:54 ` Gerd Hoffmann [this message]
2023-01-16 23:31 ` [PATCH V3 4/4] OvmfPkg/PeilessStartupLib: Find NCCFV in non-td guest Min Xu
2023-01-17 10:58 ` [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx Gerd Hoffmann
2023-01-18 3:05 ` Yao, Jiewen
2023-01-18 11:07 ` Ard Biesheuvel
2023-01-18 12:07 ` [edk2-devel] " Yao, Jiewen
2023-01-18 13:43 ` Gerd Hoffmann
2023-01-18 15:35 ` Ard Biesheuvel
2023-01-18 16:41 ` Yao, Jiewen
2023-01-18 16:49 ` Ard Biesheuvel
2023-01-19 1:50 ` Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118075413.5ivehlk34ho3n6va@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox