From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.10374.1674028460044459602 for ; Tue, 17 Jan 2023 23:54:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=grM1OQ8a; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674028459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qt/8Wi9xG/c+69nM5bUN59OfzMm6mlO3fCaCtFWsC18=; b=grM1OQ8a4aZI37edBsENOsRKqLl1BzBOe3hs4HsNOPgztD/DzbBpLdMxLaoDwRjcyLG7TI Gf0maEQin6qo8Y40N/eH3nlg5/P4hd2P+irjpjwEx8KEg5f0UgwHXVZ9U8gWBP0UATV0w4 qYZez6DxitHNkB8wO9Te6TjGtpPpRD0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-h1r7WMycPDSYwrU1DGRLyQ-1; Wed, 18 Jan 2023 02:54:16 -0500 X-MC-Unique: h1r7WMycPDSYwrU1DGRLyQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 907D71C05AE0; Wed, 18 Jan 2023 07:54:15 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 622BB492B00; Wed, 18 Jan 2023 07:54:15 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id F29531800091; Wed, 18 Jan 2023 08:54:13 +0100 (CET) Date: Wed, 18 Jan 2023 08:54:13 +0100 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V3 3/4] OvmfPkg/IntelTdx: Enable separate-fv in IntelTdx/IntelTdxX64.fdf Message-ID: <20230118075413.5ivehlk34ho3n6va@sirius.home.kraxel.org> References: <20230116233158.1268-1-min.m.xu@intel.com> <20230116233158.1268-4-min.m.xu@intel.com> <20230117105655.vcbknqjra67ribei@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 17, 2023 at 01:07:53PM +0000, Xu, Min M wrote: > On January 17, 2023 6:57 PM, Gerd Hoffmann wrote: > > > > > -INF > > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDx > > e.inf > > > > If you move the gfx console driver you can move the gfx hardware drivers > > too: > > > > OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf > > OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > > OvmfPkg/VirtioGpuDxe/VirtioGpu.inf > > > Do you mean these 3 gfx hardware drivers should be in NCCFV as GraphicsConsoleDxe is? They're are all in NCCFV. > https://github.com/mxu9/edk2/blob/Separate-Fv.v3/OvmfPkg/IntelTdx/IntelTdxX64.fdf#L298 > https://github.com/mxu9/edk2/blob/Separate-Fv.v3/OvmfPkg/IntelTdx/IntelTdxX64.fdf#L330-L333 Good. I missed them being moved down, but sees this was not needed in the first place ;) take care, Gerd