From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.10986.1674032431233564164
 for <devel@edk2.groups.io>;
 Wed, 18 Jan 2023 01:00:31 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AYOpHUTg;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674032429;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=95B97BfVbP1tcF8Tm5PAS/PQ83WNsxGhd7wt/pyQwco=;
	b=AYOpHUTgoTn/fAL8xdWKY6BrbxdKsoQMnkXqLOCQeoYBuFEaf2z3WK5d85rwOsPS89dr77
	fS1gvqDFzvTR+fu3IEwdSI8KiueY2eBV4MuqtKX0JtrMlqpUuB8uDrjhPjWavZs4tOuUDw
	pf8JSi6aO1tZ9H2zb0SpMmwua3wlyAM=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-223-VyCP00RiPy6kqRE30rG3UQ-1; Wed, 18 Jan 2023 04:00:23 -0500
X-MC-Unique: VyCP00RiPy6kqRE30rG3UQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19BA6811E6E;
	Wed, 18 Jan 2023 09:00:23 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id CC761140EBF6;
	Wed, 18 Jan 2023 09:00:22 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 98F661800091; Wed, 18 Jan 2023 10:00:20 +0100 (CET)
Date: Wed, 18 Jan 2023 10:00:20 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V2 1/1] OvmfPkg/BaseMemEncryptTdxLib: Refactor error handle of SetOrClearSharedBit
Message-ID: <20230118090020.p6npzshstucakc5a@sirius.home.kraxel.org>
References: <20230117235232.242-1-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230117235232.242-1-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 18, 2023 at 07:52:32AM +0800, Min Xu wrote:
> From: Min M Xu <min.m.xu@intel.com>
> 
> The previous implementation of SetOrClearSharedBit doesn't handle the
> error correctly. In this patch SetOrClearSharedBit is changed to return
> error code so that the caller can handle it.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>