* [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool
@ 2023-01-18 8:41 Min Xu
2023-01-18 9:06 ` Gerd Hoffmann
2023-01-18 10:03 ` Yao, Jiewen
0 siblings, 2 replies; 4+ messages in thread
From: Min Xu @ 2023-01-18 8:41 UTC (permalink / raw)
To: devel
Cc: Min M Xu, Liming Gao, Dandan Bi, Erdem Aktas, James Bottomley,
Jiewen Yao, Gerd Hoffmann, Tom Lendacky, Michael Roth
From: Min M Xu <min.m.xu@intel.com>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4315
MemoryType of EfiUnacceptedMemoryType should not be allocated in
AllocatePool. Instead it should return EFI_INVALID_PARAMETER.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Michael Roth <michael.roth@amd.com>
Reported-by: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Min Xu <min.m.xu@intel.com>
---
MdeModulePkg/Core/Dxe/Mem/Pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Dxe/Mem/Pool.c b/MdeModulePkg/Core/Dxe/Mem/Pool.c
index 7aaf501600cf..b20cbfdedbab 100644
--- a/MdeModulePkg/Core/Dxe/Mem/Pool.c
+++ b/MdeModulePkg/Core/Dxe/Mem/Pool.c
@@ -213,7 +213,7 @@ CoreInternalAllocatePool (
// If it's not a valid type, fail it
//
if (((PoolType >= EfiMaxMemoryType) && (PoolType < MEMORY_TYPE_OEM_RESERVED_MIN)) ||
- (PoolType == EfiConventionalMemory) || (PoolType == EfiPersistentMemory))
+ (PoolType == EfiConventionalMemory) || (PoolType == EfiPersistentMemory) || (PoolType == EfiUnacceptedMemoryType))
{
return EFI_INVALID_PARAMETER;
}
--
2.29.2.windows.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool
2023-01-18 8:41 [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool Min Xu
@ 2023-01-18 9:06 ` Gerd Hoffmann
2023-01-18 10:03 ` Yao, Jiewen
1 sibling, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2023-01-18 9:06 UTC (permalink / raw)
To: Min Xu
Cc: devel, Liming Gao, Dandan Bi, Erdem Aktas, James Bottomley,
Jiewen Yao, Tom Lendacky, Michael Roth
On Wed, Jan 18, 2023 at 04:41:58PM +0800, Min Xu wrote:
> From: Min M Xu <min.m.xu@intel.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4315
>
> MemoryType of EfiUnacceptedMemoryType should not be allocated in
> AllocatePool. Instead it should return EFI_INVALID_PARAMETER.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool
2023-01-18 8:41 [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool Min Xu
2023-01-18 9:06 ` Gerd Hoffmann
@ 2023-01-18 10:03 ` Yao, Jiewen
2023-01-19 1:08 ` 回复: [edk2-devel] " gaoliming
1 sibling, 1 reply; 4+ messages in thread
From: Yao, Jiewen @ 2023-01-18 10:03 UTC (permalink / raw)
To: Xu, Min M, devel@edk2.groups.io
Cc: Gao, Liming, Bi, Dandan, Aktas, Erdem, James Bottomley,
Gerd Hoffmann, Tom Lendacky, Michael Roth
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Wednesday, January 18, 2023 4:42 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Bi, Dandan <dandan.bi@intel.com>; Aktas,
> Erdem <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Tom Lendacky <thomas.lendacky@amd.com>; Michael Roth
> <michael.roth@amd.com>
> Subject: [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not
> allowed in AllocatePool
>
> From: Min M Xu <min.m.xu@intel.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4315
>
> MemoryType of EfiUnacceptedMemoryType should not be allocated in
> AllocatePool. Instead it should return EFI_INVALID_PARAMETER.
>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Reported-by: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> ---
> MdeModulePkg/Core/Dxe/Mem/Pool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Core/Dxe/Mem/Pool.c
> b/MdeModulePkg/Core/Dxe/Mem/Pool.c
> index 7aaf501600cf..b20cbfdedbab 100644
> --- a/MdeModulePkg/Core/Dxe/Mem/Pool.c
> +++ b/MdeModulePkg/Core/Dxe/Mem/Pool.c
> @@ -213,7 +213,7 @@ CoreInternalAllocatePool (
> // If it's not a valid type, fail it
> //
> if (((PoolType >= EfiMaxMemoryType) && (PoolType <
> MEMORY_TYPE_OEM_RESERVED_MIN)) ||
> - (PoolType == EfiConventionalMemory) || (PoolType ==
> EfiPersistentMemory))
> + (PoolType == EfiConventionalMemory) || (PoolType ==
> EfiPersistentMemory) || (PoolType == EfiUnacceptedMemoryType))
> {
> return EFI_INVALID_PARAMETER;
> }
> --
> 2.29.2.windows.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool
2023-01-18 10:03 ` Yao, Jiewen
@ 2023-01-19 1:08 ` gaoliming
0 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2023-01-19 1:08 UTC (permalink / raw)
To: devel, jiewen.yao, 'Xu, Min M'
Cc: 'Bi, Dandan', 'Aktas, Erdem',
'James Bottomley', 'Gerd Hoffmann',
'Tom Lendacky', 'Michael Roth'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen
> 发送时间: 2023年1月18日 18:04
> 收件人: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
> 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Bi, Dandan
> <dandan.bi@intel.com>; Aktas, Erdem <erdemaktas@google.com>; James
> Bottomley <jejb@linux.ibm.com>; Gerd Hoffmann <kraxel@redhat.com>; Tom
> Lendacky <thomas.lendacky@amd.com>; Michael Roth
> <michael.roth@amd.com>
> 主题: Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg:
> EfiUnacceptedMemoryType is not allowed in AllocatePool
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: Xu, Min M <min.m.xu@intel.com>
> > Sent: Wednesday, January 18, 2023 4:42 PM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m.xu@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Bi, Dandan <dandan.bi@intel.com>; Aktas,
> > Erdem <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>;
> > Yao, Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>;
> > Tom Lendacky <thomas.lendacky@amd.com>; Michael Roth
> > <michael.roth@amd.com>
> > Subject: [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not
> > allowed in AllocatePool
> >
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4315
> >
> > MemoryType of EfiUnacceptedMemoryType should not be allocated in
> > AllocatePool. Instead it should return EFI_INVALID_PARAMETER.
> >
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Michael Roth <michael.roth@amd.com>
> > Reported-by: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> > ---
> > MdeModulePkg/Core/Dxe/Mem/Pool.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Core/Dxe/Mem/Pool.c
> > b/MdeModulePkg/Core/Dxe/Mem/Pool.c
> > index 7aaf501600cf..b20cbfdedbab 100644
> > --- a/MdeModulePkg/Core/Dxe/Mem/Pool.c
> > +++ b/MdeModulePkg/Core/Dxe/Mem/Pool.c
> > @@ -213,7 +213,7 @@ CoreInternalAllocatePool (
> > // If it's not a valid type, fail it
> > //
> > if (((PoolType >= EfiMaxMemoryType) && (PoolType <
> > MEMORY_TYPE_OEM_RESERVED_MIN)) ||
> > - (PoolType == EfiConventionalMemory) || (PoolType ==
> > EfiPersistentMemory))
> > + (PoolType == EfiConventionalMemory) || (PoolType ==
> > EfiPersistentMemory) || (PoolType == EfiUnacceptedMemoryType))
> > {
> > return EFI_INVALID_PARAMETER;
> > }
> > --
> > 2.29.2.windows.2
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-19 1:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-18 8:41 [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool Min Xu
2023-01-18 9:06 ` Gerd Hoffmann
2023-01-18 10:03 ` Yao, Jiewen
2023-01-19 1:08 ` 回复: [edk2-devel] " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox