From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.13527.1674044411505963159
 for <devel@edk2.groups.io>;
 Wed, 18 Jan 2023 04:20:11 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KSH4koBo;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674044410;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=YcQjWorBSKRGwJTuFb+1J5J31jraT2nooIFOXBNq7Nc=;
	b=KSH4koBorB+V91XQl11EegpaiBUS4miokE1ps9iZLlrjhEhUFw5b/9JXntKdUCEGnAf8+x
	/jPEUQMmog2bLzgwGQauJeGDEerGXafNgPVGKMyRZAW3un4YFlsvH+YPKI4A7KsFaSOekr
	5LJeCdv7txPXNrHgHN+TACHkBPh5fSQ=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-297-UaSR0C2zNaGQ-0JZ3eAISQ-1; Wed, 18 Jan 2023 07:20:06 -0500
X-MC-Unique: UaSR0C2zNaGQ-0JZ3eAISQ-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E9FC2932481;
	Wed, 18 Jan 2023 12:20:06 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0908140C2064;
	Wed, 18 Jan 2023 12:20:00 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 6A0DD1800091; Wed, 18 Jan 2023 13:19:58 +0100 (CET)
Date: Wed, 18 Jan 2023 13:19:58 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration
Message-ID: <20230118121958.cxbfh3fljedvebis@sirius.home.kraxel.org>
References: <20230118095620.9860-1-jiaxin.wu@intel.com>
 <20230118095620.9860-6-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230118095620.9860-6-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 18, 2023 at 05:56:20PM +0800, Jiaxin Wu wrote:
> This patch is to avoid configure SMBASE if SmBase relocation has been
> done. If gSmmBaseHobGuid found, means SmBase info has been relocated
> and recorded in the SmBase array. No need to do the relocation in
> SmmCpuFeaturesInitializeProcessor().

Still not answered:  Who produces the gSmmBaseHobGuid?

If you intend to submit the producer code to edk2 please do so as part
of this patch series, so it is possible to see the whole picture instead
of only some pieces of the puzzle when reviewing the code.

If you don't submit the producer code it is pointless to touch OVMF.
You are only adding dead code.  That would be a rather questionable
decision though and add a big question mark to intels open source
commitment.

take care,
  Gerd