From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.40654.1674114790098265376 for ; Wed, 18 Jan 2023 23:53:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cyhO2zv4; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674114788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2CjJ+WihE59bt3dWJx3My0sLReeawX2qHwYXbrWlKN0=; b=cyhO2zv4M1Z3eyVibNPCuxYo6Kjc1jTWz0MTSJ8hsT8g2G6Ouvd1Qljwhb8Ji5zALUD6Dc hBUeBIzeXawzghF9yeDoi4IRGjAKPWgBYe7Bez0LnOOwFS6MZeev/BYYZzIHwF/BgZ/l+2 xVlZTdl/QT/7qkTKHG27jqOxc2k9aE4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-136-mbtuYX5pNCqngmnN1Nksmg-1; Thu, 19 Jan 2023 02:53:05 -0500 X-MC-Unique: mbtuYX5pNCqngmnN1Nksmg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B399299E74D; Thu, 19 Jan 2023 07:53:05 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C971540C6EC4; Thu, 19 Jan 2023 07:53:04 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6B593180093C; Thu, 19 Jan 2023 08:53:03 +0100 (CET) Date: Thu, 19 Jan 2023 08:53:03 +0100 From: "Gerd Hoffmann" To: "Ni, Ray" Cc: "Wu, Jiaxin" , "devel@edk2.groups.io" , "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Message-ID: <20230119075303.nkyno36h25xscwkn@sirius.home.kraxel.org> References: <20230118095620.9860-1-jiaxin.wu@intel.com> <20230118095620.9860-6-jiaxin.wu@intel.com> <20230118121958.cxbfh3fljedvebis@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 18, 2023 at 02:37:11PM +0000, Ni, Ray wrote: > Gerd, > I think comments from patch #1 explains: Not, it doesn't. We are running in circles. I keep asking about the producer, you are answering that saying what the consumer should do. So, you apparently want do SMM initialization earlier, in some PEI module. OK. Open questions: * Why do you want do it in PEI instead? The cover letter claims this improves boot performance. I don't buy that. You are not skipping the relocation process, you are just doing it somewhere else. * Where is the code? * It is totally unclear whenever it is possible and/or useful to initialize SMM that way on OVMF. take care, Gerd