From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.40389.1674114844876742415
 for <devel@edk2.groups.io>;
 Wed, 18 Jan 2023 23:54:05 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QqeSH0cc;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674114844;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iz18Am1eLLvEj16PC5onUz5SVzpdX4lR4n8cq+eZRss=;
	b=QqeSH0ccLP9tZOpToNxnV2uQfpBh0BC2wTkZYOy4Zl+OXkdENtvH/dalpM6pFFAmWAiQtZ
	OTUYgPpfyre683oH8eTiFFF6fmgMLsZDmtkKHhClfEFeHVXUzR5flMEowyeCQtEq19Q+W9
	+xWJGwbCzZbwMaO3bwyTJlE+854Crmw=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-138-DYCOOckkMOOC9L8YId-lPQ-1; Thu, 19 Jan 2023 02:54:02 -0500
X-MC-Unique: DYCOOckkMOOC9L8YId-lPQ-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F2F93804089;
	Thu, 19 Jan 2023 07:54:02 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 540D740C6EC4;
	Thu, 19 Jan 2023 07:54:02 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id EAD37180093C; Thu, 19 Jan 2023 08:54:00 +0100 (CET)
Date: Thu, 19 Jan 2023 08:54:00 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: sebastien.boeuf@intel.com
Cc: devel@edk2.groups.io, jiewen.yao@intel.com
Subject: Re: [PATCH] OvmfPkg: Report proper address space width for Cloud Hypervisor
Message-ID: <20230119075400.wb2p35gboegb3rdp@sirius.home.kraxel.org>
References: <4354b16fa5364a6b0e77e787582136e45e5f325b.1674051530.git.sebastien.boeuf@intel.com>
MIME-Version: 1.0
In-Reply-To: <4354b16fa5364a6b0e77e787582136e45e5f325b.1674051530.git.sebastien.boeuf@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 18, 2023 at 03:20:15PM +0100, sebastien.boeuf@intel.com wrote:
> From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> 
> The address space width isn't properly calculated when the platform is
> Cloud Hypervisor. The function PlatformAddressWidthFromCpuid() must not
> be invoked with the QemuQuirk boolean set to true in the Cloud
> Hypervisor case.
> 
> Relying on the host bridge identifier, we can set the QemuQuirk to the
> appropriate value, which results in the address space size to be
> correctly returned for Cloud Hypervisor.
> 
> Having the correct address space width allows the code to calculate
> dynamically the MMIO space available for devices in the 64-bit address
> space, preventing it to fallback onto the default value (32GiB).
> 
> Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>