From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.40674.1674114943365573253
 for <devel@edk2.groups.io>;
 Wed, 18 Jan 2023 23:55:43 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gvvs5KS5;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674114942;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TAg0WLmCMV+j5JyqhzRm5/7QlCYEvf61ish14TsLljM=;
	b=gvvs5KS5EvaQ0K1iInnncNBALR0SktCUz3pezTrKlhx68Y277nblaF2tz8Mk4faIQg3S/j
	HIorOPZiJbwYE7wgKzVvwlB/5dKP1/iVOP7ttbbUfxkMTbKH1DePhkCIL5YHHUbXyCjEk8
	yNzIzvWZA73LOajvfXhi9EOvz/Aoe/4=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-44-qyaB7f4NPrqCygG10ZJ4Ig-1; Thu, 19 Jan 2023 02:55:36 -0500
X-MC-Unique: qyaB7f4NPrqCygG10ZJ4Ig-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A93D18A0109;
	Thu, 19 Jan 2023 07:55:35 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 61388492B00;
	Thu, 19 Jan 2023 07:55:35 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 4581D180093C; Thu, 19 Jan 2023 08:55:32 +0100 (CET)
Date: Thu, 19 Jan 2023 08:55:32 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Abner Chang <abner.chang@amd.com>,
	Daniel Schaefer <git@danielschaefer.me>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg
Message-ID: <20230119075532.himdt6ym6epczsyv@sirius.home.kraxel.org>
References: <20230119015108.1323-1-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230119015108.1323-1-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 19, 2023 at 09:51:06AM +0800, Min Xu wrote:
> Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the
> second input parameter in FfsFindSectionData. This change breaks the build
> of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData
> is renamed as FfsFindSectionDataWithHook. Then the original
> FfsFindSectionData is added back.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>