From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.41870.1674120790873627568
 for <devel@edk2.groups.io>;
 Thu, 19 Jan 2023 01:33:11 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FXApDg2L;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674120790;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9HXa/YbFuIg16icSlEiyxXTST+iejmoV5ayqsD8WekA=;
	b=FXApDg2Ld8LM/aJiHeM2eKJQez37jCyGXRQdyIlBv8sXWtLKKdsXMGWvhvjZLOYjNwsUVS
	O45dVx4sWDiX09F4maIHrEY2Ny0YgV3YYuMkJ03lIHnuEWxXMZYivFmo2NJ8Z5bgI7Hud6
	/1UFUz7gSB4xDw1d4PvRWtYOm8a+Q9Q=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-387-C1BMlqZiOvG-KOhYfEWneA-1; Thu, 19 Jan 2023 04:33:04 -0500
X-MC-Unique: C1BMlqZiOvG-KOhYfEWneA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64FBD185A78B;
	Thu, 19 Jan 2023 09:33:04 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 264271121315;
	Thu, 19 Jan 2023 09:33:04 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id C6909180093C; Thu, 19 Jan 2023 10:33:02 +0100 (CET)
Date: Thu, 19 Jan 2023 10:33:02 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V2 03/10] OvmfPkg/IntelTdx: Add SecTdxHelperLib
Message-ID: <20230119093302.rkl2rfzh62qlxwwu@sirius.home.kraxel.org>
References: <20230119032822.1406-1-min.m.xu@intel.com>
 <20230119032822.1406-4-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230119032822.1406-4-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> TdxHelperLib provides below helper functions for a td-guest.
>  - TdxHelperProcessTdHob

This is moved over from PlatformInitLib.

>  - TdxHelperMeasureTdHob
>  - TdxHelperMeasureCfvImage
>  - TdxHelperBuildGuidHobForTdxMeasurement

This is new.

> In this patch only TdxHelperProcessTdHob is implemented. Other 3 functions
> are to be implemented in the following patch. This is because the code of
> TdxHelperProcessTdHob is copied from PlatformInitLib/IntelTdx.c.

Why copy?  You should be able to move the code over in one patch.  Maybe
it's easier to do so at the end of the series, i.e. drop this patch and
the last patch moves the code instead of deleting it.

take care,
  Gerd