From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.41619.1674120810850712893 for ; Thu, 19 Jan 2023 01:33:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RPG1wbTm; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674120809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OltgTb+ClmAqoqSmjaJTUNRa5uk57zWcNwcUebCn95I=; b=RPG1wbTmxs3UowiiX4ECqtUORzNr5sDrmscqBxwIQBdEJPeVYepNFr9b0pykABB75lSh1/ HzCvZrla0wcF8tVwZ67qzq2VSFYNg3+eLTIuZqSPOoY5ClSFjConGRFisnFhZ3t3Q4kipQ +pYG+gB8gwuJpnvET+A+05/fjjzC2xw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-F_24Rz1UPDy0IYVZzdXDMw-1; Thu, 19 Jan 2023 04:33:26 -0500 X-MC-Unique: F_24Rz1UPDy0IYVZzdXDMw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B898E811E6E; Thu, 19 Jan 2023 09:33:25 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 890332166B2A; Thu, 19 Jan 2023 09:33:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 39E51180093C; Thu, 19 Jan 2023 10:33:24 +0100 (CET) Date: Thu, 19 Jan 2023 10:33:24 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Michael Roth Subject: Re: [PATCH V2 01/10] OvmfPkg: Add Tdx measurement data structure in WorkArea Message-ID: <20230119093324.onhfi2fxz3hipun4@sirius.home.kraxel.org> References: <20230119032822.1406-1-min.m.xu@intel.com> <20230119032822.1406-2-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <20230119032822.1406-2-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 19, 2023 at 11:28:13AM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 > > From the perspective of security any external input should be measured > and extended to some registers (TPM PCRs or TDX RTMR registers). > > There are below 2 external input in a Td guest: > - TdHob > - Configuration FV (CFV) > > TdHob contains the resource information passed from VMM, such as > unaccepted memory region. CFV contains the configurations, such as > secure boot variables. > > TdHob and CFV should be measured and extended to RTMRs before they're > consumed. TdHob is consumed in the very early stage of boot process. > At that moment the memory service is not ready. Cfv is consumed in > PlatformPei to initialize the EmuVariableNvStore. To make the > implementation simple and clean, these 2 external input are measured > and extended to RTMRs in SEC phase. That is to say the tdx measurement > is only supported in SEC phase. > > After the measurement the hash values are stored in WorkArea. Then after > the Hob service is available, these 2 measurement values are retrieved > and GuidHobs for these 2 tdx measurements are generated. > > This patch defines the structure of TDX_MEASUREMENTS_DATA in > SEC_TDX_WORK_AREA to store above 2 tdx measurements. It can be extended > to store more tdx measurements if needed in the future. Acked-by: Gerd Hoffmann