From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.41826.1674122100247311234
 for <devel@edk2.groups.io>;
 Thu, 19 Jan 2023 01:55:00 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OJ6or5rc;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674122099;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vXHxZsjgWW4GKG3At6E0TqoE+ple3xprJ7hyzJSRJqg=;
	b=OJ6or5rcTQq1N0SVB38nz8bh6qamdD3lKDc549vD+0O3AGvxXvWj0eyEc0vCpjhIEzqjIE
	DllPZjk9lAOaxmg2F/1SEjhmxEMoUY9Qt3Epaer+x0VRSWo933TR4ThFtcAq3jqIMZrpbe
	GakzXpx2SAtAtmmd5MEjffIUZHdKqaY=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-16-E-xHitIBMLeqYi0nWThDVg-1; Thu, 19 Jan 2023 04:54:55 -0500
X-MC-Unique: E-xHitIBMLeqYi0nWThDVg-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75C2E85CBE1;
	Thu, 19 Jan 2023 09:54:55 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 48EFA492B00;
	Thu, 19 Jan 2023 09:54:55 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 03739180093C; Thu, 19 Jan 2023 10:54:54 +0100 (CET)
Date: Thu, 19 Jan 2023 10:54:53 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V2 05/10] OvmfPkg/IntelTdx: Add PeiTdxHelperLib
Message-ID: <20230119095453.jajaj3i24fydhayk@sirius.home.kraxel.org>
References: <20230119032822.1406-1-min.m.xu@intel.com>
 <20230119032822.1406-6-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230119032822.1406-6-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 19, 2023 at 11:28:17AM +0800, Min Xu wrote:
> From: Min M Xu <min.m.xu@intel.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
> 
> TdxHelperLib provides below helper functions for a td-guest.
>  - TdxHelperProcessTdHob
>  - TdxHelperMeasureTdHob
>  - TdxHelperMeasureCfvImage
>  - TdxHelperBuildGuidHobForTdxMeasurement
> 
> PeiTdxHelperLib is the PEI instance of TdxHelperLib. It implements 1
> function for tdx in PEI phase. Other functions are not supported in
> PEI phase.
>   - TdxHelperBuildGuidHobForTdxMeasurement builds GuidHob for tdx
>     measurement in PEI phase.
> 
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>