From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.71038.1674209916736383679
 for <devel@edk2.groups.io>;
 Fri, 20 Jan 2023 02:18:37 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KlyZAj8X;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674209915;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5bJ5yBY/7/2vVhGWrf93uELWo3tN1SwMewMFdx2HvbQ=;
	b=KlyZAj8XWS+ZL0zyPlubn6jGJZGRGBjP+cpz2Tpci/Ug3hsY1iOnJOUQ1JOkLEWQFC25q7
	+d5TaAN1sXedM7UgnKQRky2B7HukF97jBLOtLxtrD2WO5uR8z21R6qtMMejGzmeiKupqeF
	Q7n68xNZdS6I88R/lJKpIZmu5h8cJzw=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-558-ZrUdvAcWNqWWlBRDL9mKpQ-1; Fri, 20 Jan 2023 05:18:30 -0500
X-MC-Unique: ZrUdvAcWNqWWlBRDL9mKpQ-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CAB041C05B06;
	Fri, 20 Jan 2023 10:18:29 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 91E97492B02;
	Fri, 20 Jan 2023 10:18:29 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 3EBE118007AC; Fri, 20 Jan 2023 11:18:28 +0100 (CET)
Date: Fri, 20 Jan 2023 11:18:28 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Xu, Min M" <min.m.xu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib
Message-ID: <20230120101828.jf43j7ahxqossace@sirius.home.kraxel.org>
References: <20230119032822.1406-1-min.m.xu@intel.com>
 <20230119032822.1406-5-min.m.xu@intel.com>
 <20230119095422.ou5vbckdyn33hh5c@sirius.home.kraxel.org>
 <PH0PR11MB50645600261C653EF5457F55C5C59@PH0PR11MB5064.namprd11.prod.outlook.com>
 <MW4PR11MB587210EA47756443B289D8758CC59@MW4PR11MB5872.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <MW4PR11MB587210EA47756443B289D8758CC59@MW4PR11MB5872.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 20, 2023 at 08:10:45AM +0000, Yao, Jiewen wrote:
> > Can we define FV_HANDOFF_TABLE_POINTERS2 and FV_HANDOFF_TABLE_POINTERS2 in MdePkg/Include/IndustryStandard/UefiTcgPlatform.h?
> 
> [Jiewen] No. We cannot move to MdePkg.
> TCG defines the field to be variable length. Something like below:
> 
> typedef struct {
>   UINT8                      TableDescriptionSize;
>   UINT8                      TableDescription[TableDescriptionSize];
>   UINT64                     NumberOfTables;
>   EFI_CONFIGURATION_TABLE    TableEntry[NumberOfTables];
> } HANDOFF_TABLE_POINTERS2;
> 
> typedef struct {
>   UINT8                   BlobDescriptionSize;
>   UINT8                   BlobDescription[BlobDescriptionSize];
>   EFI_PHYSICAL_ADDRESS    BlobBase;
>   UINT64                  BlobLength;
> } HANDOFF_TABLE_POINTERS2;
> 
> The implementation can choose its own length as they wish.

Why doesn't follow TDX standard TCG practices here?

take care,
  Gerd