From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.41359.1674638293798234200
 for <devel@edk2.groups.io>;
 Wed, 25 Jan 2023 01:18:14 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VWBylCNG;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674638292;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=WMNo0JujZZ8ZjJmA0rmumvTybsOyTKSWq0Df+0SU3lg=;
	b=VWBylCNGnlI1VdrvS1ko1i8zvyt+Ef2gzMVhKCmL7QSggMxIlG/yoVGrUR10BXObhCssjr
	jKuOZ63qOdKXFTtf2QxBOxvEFX5jY+Ymms2LqX5zhltQOjet8deXzLtpicrAxXm+zUYUw9
	Lt9K76mOyf5XeMlq8Cj3W/L+4MmO/E4=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-247-xzL5dG1CMemGLhd2Hor0xQ-1; Wed, 25 Jan 2023 04:18:08 -0500
X-MC-Unique: xzL5dG1CMemGLhd2Hor0xQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 517891C270AA;
	Wed, 25 Jan 2023 09:18:08 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.186])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id C54AF51FF;
	Wed, 25 Jan 2023 09:18:07 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id EADA81800623; Wed, 25 Jan 2023 10:18:02 +0100 (CET)
Date: Wed, 25 Jan 2023 10:18:02 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, thomas.lendacky@amd.com, dave.hansen@intel.com,
	dionnaglaze@google.com, dave.hansen@linux.intel.com,
	Jiewen <jiewen.yao@intel.com>,
	"Shutemov, Kirill" <kirill.shutemov@intel.com>
Subject: Re: [edk2-devel] [PATCH v9 0/4] Add safe unaccepted memory behavior
Message-ID: <20230125091802.yya2a3cqlcmxzv2x@sirius.home.kraxel.org>
References: <MW4PR11MB58725ED9D912BDC299E821538CC29@MW4PR11MB5872.namprd11.prod.outlook.com>
 <16581.1673625639418051810@groups.io>
 <CAAH4kHYgN1ZVevP7mDRT27bpjj+0tkyAVbtznzyfYVuryBU=2g@mail.gmail.com>
 <0918b9db-c949-75ce-a24e-f12f03865938@intel.com>
 <CAAH4kHa1WU_6505fYyvp=06RGyPoh_-Do++7oib=T23hEgy9ug@mail.gmail.com>
 <d2ff3032-5fa6-7d3e-67f0-ce0d7a9a7fdd@intel.com>
 <20230116102801.y3l6xn3gdgregn4k@sirius.home.kraxel.org>
 <d27b6d42-4753-2989-a5d3-bcc683efc1d3@amd.com>
 <CAMj1kXHLWTOORY5kqSi1=FOGwYArS7_rorKzU-VrvN3LfErdcQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAMj1kXHLWTOORY5kqSi1=FOGwYArS7_rorKzU-VrvN3LfErdcQ@mail.gmail.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote:
 
> Exactly. And my Fedora kernel has those bits enabled by default.
> 
> So I suppose the way forward here is to expose this protocol only on
> OVMF builds that target SEV-SNP, instead of introducing it as a
> generic CoCo feature.

OVMF builds already adapt at runtime, so this needs to be a runtime
check too.  But IIRC the module already checks whenever SNP-SEV or TDX
is active before installing, so we only need to tweak that check to drop
the TDX check.

take care,
  Gerd