From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.42334.1674642515991591105 for ; Wed, 25 Jan 2023 02:28:36 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 557C7C14; Wed, 25 Jan 2023 02:29:17 -0800 (PST) Received: from cam-smtp0.cambridge.arm.com (pierre123.nice.arm.com [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DA7D43F71E; Wed, 25 Jan 2023 02:28:33 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Thomas Abraham , Sami Mujawar , Leif Lindholm , Wenyi Xie , Ilias Apalodimas , Omkar Anand Kulkarni , Pranav Madhu , Sayanta Pattanayak , Pierre Gondois Subject: [PATCH edk2-platforms 1/5] Platform/ARM/SgiPkg: Remove '-march=armv8-a+nofp' flag Date: Wed, 25 Jan 2023 11:27:58 +0100 Message-Id: <20230125102802.663790-2-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230125102802.663790-1-Pierre.Gondois@arm.com> References: <20230125102802.663790-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: Pierre Gondois The '-march=3Darmv8-a+nofp' flag abort the following build: build -a AARCH64 -p Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc -t GCC5 -D SECURE_STORAGE_ENABLE Error message: CryptoPkg/Library/OpensslLib/openssl/crypto/rand/drbg_lib.c:1009:12: error: =E2=80=98+nofp=E2=80=99 feature modifier is incompatible with th= e use of floating-point types static int drbg_add(const void *buf, int num, double randomness) ^~~~~~~~ In SgiPlatformMm.dsc.inc, the '-march=3Darmv8-a+nofp' flag was originally added in: commit 1974293d1975 ("Platform/ARM/SgiPkg: Build infrastructure for StandaloneMm image") as a linker flag. The flag seem to have been added to avoid triggering an exception due to the floating point unit missing in RTL. With the latest RTL, the exception is not triggered anymore. commit 936e8dd57524 ("Platform/Sgi: Cleanup build options for StandaloneMM context") moves the flag from the linker to the compiler, making the build fail. Remove the '-march=3Darmv8-a+nofp' flag as it is not necessary anymore for SgiPlatformMm.dsc.inc, and is probably not necessary for PlatformStandaloneMmRpmb.dsc. CC: Omkar Anand Kulkarni CC: Pranav Madhu CC: Sayanta Pattanayak Signed-off-by: Pierre Gondois --- Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/Sgi= Pkg/SgiPlatformMm.dsc.inc index 01f0a7657c51..f9a516b341f0 100644 --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc @@ -146,5 +146,5 @@ [Components.AARCH64] # ########################################################################= ########################### [BuildOptions.AARCH64] - GCC:*_*_*_CC_FLAGS =3D -mstrict-align -march=3Darmv8-a+nofp -D DISABLE= _NEW_DEPRECATED_INTERFACES + GCC:*_*_*_CC_FLAGS =3D -mstrict-align -D DISABLE_NEW_DEPRECATED_INTERF= ACES GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 --=20 2.25.1