public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: devel@edk2.groups.io
Cc: Min M Xu <min.m.xu@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: [PATCH V4 08/12] OvmfPkg/TdxHelperLib: Implement TdxHelperBuildGuidHobForTdxMeasurement
Date: Fri, 27 Jan 2023 08:11:02 +0800	[thread overview]
Message-ID: <20230127001106.2038-9-min.m.xu@intel.com> (raw)
In-Reply-To: <20230127001106.2038-1-min.m.xu@intel.com>

From: Min M Xu <min.m.xu@intel.com>

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243

TdxHelperBuildGuidHobForTdxMeasurement builds GuidHob for tdx-measurement
which is measured in SEC phase. The implementation is movded from
PeilessStartupLib/IntelTdx.c.

Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Michael Roth <michael.roth@amd.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>
---
 OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c     | 16 ++++++++++++++++
 .../IntelTdx/TdxHelperLib/SecTdxHelperLib.inf    |  1 +
 .../TdxHelperLib/TdxMeasurementHob.c}            |  9 +++++----
 .../PeilessStartupLib/PeilessStartupLib.inf      |  1 -
 4 files changed, 22 insertions(+), 5 deletions(-)
 rename OvmfPkg/{Library/PeilessStartupLib/IntelTdx.c => IntelTdx/TdxHelperLib/TdxMeasurementHob.c} (95%)

diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
index f64071827658..c857fe2ed06f 100644
--- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
+++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
@@ -23,6 +23,18 @@
 #include <ConfidentialComputingGuestAttr.h>
 #include <Library/TdxHelperLib.h>
 
+/**
+  Build the GuidHob for tdx measurements which were done in SEC phase.
+  The measurement values are stored in WorkArea.
+
+  @retval EFI_SUCCESS  The GuidHob is built successfully
+  @retval Others       Other errors as indicated
+**/
+EFI_STATUS
+InternalBuildGuidHobForTdxMeasurement (
+  VOID
+  );
+
 /**
   In Tdx guest, some information need to be passed from host VMM to guest
   firmware. For example, the memory resource, etc. These information are
@@ -208,5 +220,9 @@ TdxHelperBuildGuidHobForTdxMeasurement (
   VOID
   )
 {
+ #ifdef TDX_PEI_LESS_BOOT
+  return InternalBuildGuidHobForTdxMeasurement ();
+ #else
   return EFI_UNSUPPORTED;
+ #endif
 }
diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelperLib.inf b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelperLib.inf
index 3c6b96f7759a..d17b84c01f20 100644
--- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelperLib.inf
+++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelperLib.inf
@@ -24,6 +24,7 @@
 
 [Sources]
   SecTdxHelper.c
+  TdxMeasurementHob.c
 
 [Packages]
   CryptoPkg/CryptoPkg.dec
diff --git a/OvmfPkg/Library/PeilessStartupLib/IntelTdx.c b/OvmfPkg/IntelTdx/TdxHelperLib/TdxMeasurementHob.c
similarity index 95%
rename from OvmfPkg/Library/PeilessStartupLib/IntelTdx.c
rename to OvmfPkg/IntelTdx/TdxHelperLib/TdxMeasurementHob.c
index 4bc6f5e95e63..a4c7095cffab 100644
--- a/OvmfPkg/Library/PeilessStartupLib/IntelTdx.c
+++ b/OvmfPkg/IntelTdx/TdxHelperLib/TdxMeasurementHob.c
@@ -1,6 +1,10 @@
 /** @file
-  Copyright (c) 2022, Intel Corporation. All rights reserved.<BR>
+  Build GuidHob for tdx measurement.
+
+  Copyright (c) 2022 - 2023, Intel Corporation. All rights reserved.<BR>
+
   SPDX-License-Identifier: BSD-2-Clause-Patent
+
 **/
 
 #include <PiPei.h>
@@ -12,11 +16,8 @@
 #include <Library/HobLib.h>
 #include <Library/PrintLib.h>
 #include <Library/TcgEventLogRecordLib.h>
-#include <Library/TpmMeasurementLib.h>
 #include <WorkArea.h>
 
-#include "PeilessStartupInternal.h"
-
 #pragma pack(1)
 
 #define HANDOFF_TABLE_DESC  "TdxTable"
diff --git a/OvmfPkg/Library/PeilessStartupLib/PeilessStartupLib.inf b/OvmfPkg/Library/PeilessStartupLib/PeilessStartupLib.inf
index 5be6baf2cef8..e77ad7bc921e 100644
--- a/OvmfPkg/Library/PeilessStartupLib/PeilessStartupLib.inf
+++ b/OvmfPkg/Library/PeilessStartupLib/PeilessStartupLib.inf
@@ -29,7 +29,6 @@
   PeilessStartup.c
   Hob.c
   DxeLoad.c
-  IntelTdx.c
   X64/VirtualMemory.c
 
 [Packages]
-- 
2.29.2.windows.2


  parent reply	other threads:[~2023-01-27  0:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27  0:10 [PATCH V4 00/12] Enable Tdx measurement in OvmfPkgX64 Min Xu
2023-01-27  0:10 ` [PATCH V4 01/12] OvmfPkg: Add Tdx measurement data structure in WorkArea Min Xu
2023-01-27  0:10 ` [PATCH V4 02/12] OvmfPkg/IntelTdx: Add TdxHelperLibNull Min Xu
2023-01-27  0:10 ` [PATCH V4 03/12] OvmfPkg/IntelTdx: Add SecTdxHelperLib Min Xu
2023-01-27  0:10 ` [PATCH V4 04/12] OvmfPkg/IntelTdx: Update tdx measurement in SEC phase Min Xu
2023-01-27  0:10 ` [PATCH V4 05/12] OvmfPkg/PeilessStartupLib: Update the define of FV_HANDOFF_TABLE_POINTERS2 Min Xu
2023-01-27  0:11 ` [PATCH V4 06/12] OvmfPkg/PeilessStartupLib: Build GuidHob for Tdx measurement Min Xu
2023-01-27  7:54   ` Gerd Hoffmann
2023-01-27 11:30     ` Min Xu
2023-01-27 11:49       ` Gerd Hoffmann
2023-01-28 11:55     ` Min Xu
2023-01-27  0:11 ` [PATCH V4 07/12] OvmfPkg/PeilessStartupLib: Call TdxHelperBuildGuidHobForTdxMeasurement Min Xu
2023-01-27  0:11 ` Min Xu [this message]
2023-01-27  0:11 ` [PATCH V4 09/12] OvmfPkg: Enable Tdx measurement in OvmfPkgX64 Min Xu
2023-01-27  0:11 ` [PATCH V4 10/12] OvmfPkg/IntelTdx: Add PeiTdxHelperLib Min Xu
2023-01-27  0:11 ` [PATCH V4 11/12] OvmfPkg/PlatformPei: Build GuidHob for Tdx measurement Min Xu
2023-01-27  0:11 ` [PATCH V4 12/12] OvmfPkg/TdxHelperLib: Implement TdxHelperProcessTdHob Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230127001106.2038-9-min.m.xu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox