From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.97799.1674808154437647399
 for <devel@edk2.groups.io>;
 Fri, 27 Jan 2023 00:29:14 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LunZWAzU;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1674808153;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=8Y7R/0SFNBWNBgcodcbQL5q2A5aQekogMiYG6Q0zYWc=;
	b=LunZWAzUrcLve9yMEIq6lBH18v8vIbcdfUCWzytwVHVa7efVNQ52hU6aF/3P5lha+wdkMo
	lRVA2w98cVyrq5kwImG7QUt6uWzcBI+xsPBSCKW4a/D+GG/4da+/3VSljhK60Muqe7xlgx
	E2NVwTbBxCvrfWPGTx7YizTPyAGsHSE=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-445-5hHtCe3fMl2BEVKkzFfV0w-1; Fri, 27 Jan 2023 03:27:14 -0500
X-MC-Unique: 5hHtCe3fMl2BEVKkzFfV0w-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED84085C069;
	Fri, 27 Jan 2023 08:27:13 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.46])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A1E8B2166B26;
	Fri, 27 Jan 2023 08:27:13 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 3D7831800606; Fri, 27 Jan 2023 09:27:12 +0100 (CET)
Date: Fri, 27 Jan 2023 09:27:12 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, lisik@google.com
Cc: pedro.falcato@gmail.com, erdemaktas@google.com, jejb@linux.ibm.com,
	jiewen.yao@intel.com, min.m.xu@intel.com, thomas.lendacky@amd.com,
	michael.roth@amd.com
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Create additional PML1 entries for large SEV-SNP VMs
Message-ID: <20230127082712.ru4wr6qhzy3exxbi@sirius.home.kraxel.org>
References: <b3f494e97062bccbf591fce90f624ae77b8f2d40.1674764281.git.lisik@google.com>
MIME-Version: 1.0
In-Reply-To: <b3f494e97062bccbf591fce90f624ae77b8f2d40.1674764281.git.lisik@google.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 26, 2023 at 08:26:40PM +0000, Mikolaj Lisik via groups.io wrote:
> Edk2 was failing, rather than creating more PML4 entries, when they
> weren't present in the initial memory acceptance flow. Because of that
> VMs with more than 512G memory were crashing. This code fixes that.
> 
> This change affects only SEV-SNP VMs.
> 
> The code was tested by successfully booting a 512G SEV-SNP VM.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>