From: "Savva Mitrofanov" <savvamtr@gmail.com>
To: devel@edk2.groups.io
Cc: "Marvin Häuser" <mhaeuser@posteo.de>,
"Pedro Falcato" <pedro.falcato@gmail.com>,
"Vitaly Cheptsov" <vit9696@protonmail.com>
Subject: [edk2-platforms][PATCH v3 00/11] Ext4Pkg: Code correctness and security improvements
Date: Fri, 27 Jan 2023 15:29:34 +0600 [thread overview]
Message-ID: <20230127092945.94389-1-savvamtr@gmail.com> (raw)
Hi all,
In v3 I rebased patches according upstream and removed already applied patches.
Also in this revision I corrected 'Fixes' tag formatting, added corrections to
Ext4GetUcs2DirentName to filter out directory entry names containing \0 as invalid
and added a fix for building using MSVC.
This patchset fixes several code problems found by fuzzing Ext4Dxe like
buffer and integer overflows, memory leaks, logic bugs and so on.
REF: https://github.com/savvamitrofanov/edk2-platforms/tree/master
Cc: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Savva Mitrofanov (11):
Ext4Pkg: Fix memory leak in Ext4RetrieveDirent
Ext4Pkg: Fix incorrect checksum metadata feature check
Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group
Ext4Pkg: Add inode number validity check
Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock
Ext4Pkg: Corrects integer overflow check logic in DiskUtil
Ext4Pkg: Check that source file is directory in Ext4OpenInternal
Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName
Ext4Pkg: Add missing exit Status in Ext4OpenDirent
Ext4Pkg: Fixes build on MSVC
Ext4Pkg: Filter out directory entry names containing \0 as invalid
Features/Ext4Pkg/Ext4Pkg.dsc | 2 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 13 ++++-
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 39 +++++++++++++++
Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 5 ++
Features/Ext4Pkg/Ext4Dxe/Directory.c | 52 ++++++++++++++------
Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 8 +--
Features/Ext4Pkg/Ext4Dxe/File.c | 23 ++++++---
Features/Ext4Pkg/Ext4Dxe/Inode.c | 6 +--
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++--
Features/Ext4Pkg/Ext4Dxe/Symlink.c | 12 ++---
10 files changed, 134 insertions(+), 42 deletions(-)
--
2.39.0
next reply other threads:[~2023-01-27 9:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 9:29 Savva Mitrofanov [this message]
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 01/11] Ext4Pkg: Fix memory leak in Ext4RetrieveDirent Savva Mitrofanov
2023-01-27 14:12 ` Pedro Falcato
2023-01-27 14:16 ` Marvin Häuser
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 02/11] Ext4Pkg: Fix incorrect checksum metadata feature check Savva Mitrofanov
2023-01-27 10:02 ` Marvin Häuser
2023-01-27 14:29 ` Pedro Falcato
2023-01-30 8:38 ` Marvin Häuser
2023-01-30 8:42 ` Savva Mitrofanov
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 03/11] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Savva Mitrofanov
2023-01-27 14:13 ` Pedro Falcato
2023-01-27 14:16 ` Marvin Häuser
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 04/11] Ext4Pkg: Add inode number validity check Savva Mitrofanov
2023-01-27 14:19 ` Pedro Falcato
2023-02-02 10:15 ` Savva Mitrofanov
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 05/11] Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock Savva Mitrofanov
2023-01-27 14:22 ` Pedro Falcato
2023-01-27 14:24 ` Marvin Häuser
2023-01-27 16:14 ` Savva Mitrofanov
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 06/11] Ext4Pkg: Corrects integer overflow check logic in DiskUtil Savva Mitrofanov
2023-01-27 14:24 ` Pedro Falcato
2023-01-27 16:10 ` Savva Mitrofanov
2023-01-27 16:21 ` Pedro Falcato
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 07/11] Ext4Pkg: Check that source file is directory in Ext4OpenInternal Savva Mitrofanov
2023-01-27 14:26 ` Pedro Falcato
2023-01-27 14:33 ` Marvin Häuser
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 08/11] Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName Savva Mitrofanov
2023-01-27 14:27 ` [edk2-devel] " Pedro Falcato
2023-01-27 14:34 ` Marvin Häuser
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 09/11] Ext4Pkg: Add missing exit Status in Ext4OpenDirent Savva Mitrofanov
2023-01-27 14:28 ` Pedro Falcato
2023-01-27 14:34 ` Marvin Häuser
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 10/11] Ext4Pkg: Fixes build on MSVC Savva Mitrofanov
2023-01-27 14:33 ` Pedro Falcato
2023-01-27 14:36 ` Marvin Häuser
2023-01-30 8:35 ` Marvin Häuser
2023-01-27 9:29 ` [edk2-platforms][PATCH v3 11/11] Ext4Pkg: Filter out directory entry names containing \0 as invalid Savva Mitrofanov
2023-01-27 10:04 ` Marvin Häuser
2023-01-27 14:09 ` Pedro Falcato
2023-01-27 14:14 ` Marvin Häuser
2023-01-30 8:48 ` Marvin Häuser
2023-01-30 8:19 ` Savva Mitrofanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127092945.94389-1-savvamtr@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox