From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mx.groups.io with SMTP id smtpd.web10.98479.1674811792817229856 for ; Fri, 27 Jan 2023 01:29:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZGJ2Vut4; spf=pass (domain: gmail.com, ip: 209.85.167.42, mailfrom: savvamtr@gmail.com) Received: by mail-lf1-f42.google.com with SMTP id bp15so7179379lfb.13 for ; Fri, 27 Jan 2023 01:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YrLO0M8Mp5A+Pu9pAP6vja/iE+7a3aHelaM1VwZyORA=; b=ZGJ2Vut4oNSR1h2aUf/ZDfSr2K+210/4XVEXbVVhFR95Bt51uNQMtdJijSRtY8/gBI ABFxIG3CO1pwkO8J3FDgRv9AydDepU4fuJ+lEVZtdBpY/i/MRhlFOIt8cNLGJl0kvsN0 9/4uMi1iN+EeBG8tkyOKHX6PfM5oEu7du+2N+3licgS7cajr1fmCVTC1IgllUBBAGsRx CMVz94OUDc8K5dYrn1k3pfQhe4NYI8leaLgb1U3wwP0uonmzEeKz7A2swbVMvrdksKAL bMNBRfccEwtCVVrLskVFL1v2twF81W+DlAi5FobJNyHRaIg0Al0jKoMP7O4EqVqhfbqO HE6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YrLO0M8Mp5A+Pu9pAP6vja/iE+7a3aHelaM1VwZyORA=; b=UmIgxZ2Or1eZc99Jt8nfwka6FxJI/bMWLNHH6/ST8mEOYWk5HoHBTJjwO7LuPKVqbs KbKx5aPBUZ/EYYT8y/EVQ89nHE7UW/Cnd/kSAZmWfk/+W5bQ2Vge1bR0BgvmNaslMVG1 j3IZISUKo1XDS/vmFUw73yYguSvd5gGk5E+Sr03abySzknBYJeFr7AtqkMYUQgNkub6b 3/BtQj5eG9zGtykNcUV02OHxzb/4kLC0TecjD82BgkvjjSErRpeZMUARC/4BddYfBAUW 5NCnlkO5d9lTnv2XBrppFBcycR0WUCU15gMtgdWJJnNb9HRP8XiY3Ii0fjDxwRhWsoOf hnLQ== X-Gm-Message-State: AFqh2koB87rfmHas6PGEy+08o+/wYO4JYUeDKpre10SbVGAuLVboQMJc vyrsfRjKVaeRkSEamnoXbABiVlpoBNPjtlMD X-Google-Smtp-Source: AMrXdXv8ELOlsrH1OrK5fe5CQqZ5KVR043XvI336ViCnX/GYc1dz+y5C2xPOU8yJm1wyGHb48RjWgw== X-Received: by 2002:ac2:434f:0:b0:4b5:9e70:ca6e with SMTP id o15-20020ac2434f000000b004b59e70ca6emr11076779lfl.17.1674811795517; Fri, 27 Jan 2023 01:29:55 -0800 (PST) Return-Path: Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id t11-20020a056512068b00b004cc8196a308sm229071lfe.98.2023.01.27.01.29.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 27 Jan 2023 01:29:55 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v3 09/11] Ext4Pkg: Add missing exit Status in Ext4OpenDirent Date: Fri, 27 Jan 2023 15:29:43 +0600 Message-Id: <20230127092945.94389-10-savvamtr@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230127092945.94389-1-savvamtr@gmail.com> References: <20230127092945.94389-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Missing EFI_OUT_OF_RESOURCES exit status on failed Ext4CreateDentry leads to NULL-pointer dereference in Ext4GetFileInfo (passing NULL buffer in Ext4ReadDir) Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: 21b1853880d5 ("Ext4Pkg: Add a directory entry tree.") Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Directory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4Dx= e/Directory.c index 2e9a58a7e329..0753a20b5377 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c @@ -267,7 +267,8 @@ Ext4OpenDirent ( } else {=0D File->Dentry =3D Ext4CreateDentry (FileName, Directory->Dentry);=0D =0D - if (!File->Dentry) {=0D + if (File->Dentry =3D=3D NULL) {=0D + Status =3D EFI_OUT_OF_RESOURCES;=0D goto Error;=0D }=0D }=0D --=20 2.39.0