From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web11.924.1675101538011170062 for ; Mon, 30 Jan 2023 09:58:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PH2q/lyT; spf=pass (domain: gmail.com, ip: 209.85.221.51, mailfrom: pedro.falcato@gmail.com) Received: by mail-wr1-f51.google.com with SMTP id t7so3565195wrp.5 for ; Mon, 30 Jan 2023 09:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oPlUkQHFmvakqXCjlKK4Sj4YcpIMW8RzHo3WyHCnfg8=; b=PH2q/lyTXA1VCOfkKX+lIqpw+zOPOgYrzWV33h+A9tubQDXxxjHn74tGiP+l+aNqP1 j3JNeB4TPRG1N9TD6hsijqJORiAy6Wd4xEnV4NmiglAzS94PHTR+4ovndBC1DnkXFz/G 9ohSz4VHP/wA6QKR9sX8Hb7e0bk6+aW+jsetu+oqU1WfIJbNTCTrkGnA52gy5JAl4eHq NYarNGVQGH5sc538GpiFUJbjgE2KKE5+4tw1Y3BvtLNL4bKReYfPofRYegbRZd1SZxrH zonqVXkWrrwvWbAp4sGqHlPAOgrhAJ1G+pMc/kvkLvd/elEInrhgPbhAWa2idfrbTyH/ /h5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oPlUkQHFmvakqXCjlKK4Sj4YcpIMW8RzHo3WyHCnfg8=; b=c8SZ+mozXx+TxIfIG5VjI/8PrqXVqroxfHTonNus2bHi5NeR+qfy0LFcjmYtXRrolG W81l+rhqcivH2dN5FFX7E8k/+SWZirJONIVG/KTRT3nY7i9XKpELKfG321lPqZDX16Rz etXxoR7teZU9H3no9LdTiEmj5PfSWs6C+4numz+0VLIYkFtQxPZM89wHIRZbQhsn4GCt XicvtoAltc09TAo1qdG2fDx/fn++fPjsIkePjkwrfDVK3TBU1W9ePJQ00KHpR0RuAw9J pCwwtn1uYF48Qq3XMDsd7Cjy3zoPvgcbyBs0pUEPIn9MZbg4uJow9E6uKYRdYXtSBwRu BWQg== X-Gm-Message-State: AO0yUKXxFTl0zCPnicoksPzZzN9sRDEIZQpfj9yG6yw2Lk0SNui82Opw BhVibe17sRSuTBgsAhqt+VQTp+XoMpxThg== X-Google-Smtp-Source: AK7set8k4x2n5jSpi68qBCyI6POsqa5CZ1RrCSM8s1kRRkgWTdZUwfVsGI4vGrXaGoETCamYmTB+EA== X-Received: by 2002:a5d:52c8:0:b0:2bf:d3ef:741 with SMTP id r8-20020a5d52c8000000b002bfd3ef0741mr11431352wrv.46.1675101536082; Mon, 30 Jan 2023 09:58:56 -0800 (PST) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id c13-20020adffb0d000000b002bfd190fd60sm11701371wrr.108.2023.01.30.09.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 09:58:55 -0800 (PST) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Pedro Falcato , =?UTF-8?q?Marvin=20H=C3=A4user?= , Savva Mitrofanov Subject: [PATCH 1/1] Ext4Pkg: Redirect internal Open("..", /) to the proper "/" Date: Mon, 30 Jan 2023 17:58:50 +0000 Message-Id: <20230130175850.27638-1-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We have been hitting many issues with ".." ASSERTing on / in internal code, so make sure that we direct /.. to /. This is safe. Signed-off-by: Pedro Falcato Cc: Marvin Häuser Reported-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Directory.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4Dxe/Directory.c index 456916453952..73d21d9f9542 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c @@ -255,7 +255,11 @@ Ext4OpenDirent ( // Using the parent's parent's dentry File->Dentry = Directory->Dentry->Parent; - ASSERT (File->Dentry != NULL); + if (!File->Dentry) { + // Someone tried .. on root, so direct them to / + // This is an illegal EFI Open() but is possible to hit from a variety of internal code + File->Dentry = Directory->Dentry; + } Ext4RefDentry (File->Dentry); } else { -- 2.39.0