From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.81]) by mx.groups.io with SMTP id smtpd.web11.14238.1675218628546818727 for ; Tue, 31 Jan 2023 18:30:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=BX8eLvy+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.93.81, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OD9eArBOQvNLY35WKAQEm7JIXzvGCK/+8e1gCQqJ89XKFG9CQbVA/UVcbAeepZaOgIjFwTX5Xm8qssrm2wOHsFp6dpvLQavTfySL8Ho7QbmW0rPNaI90vhwQXBv2Gx2vHA9NRtyiVCQ74abDjDY9MOZaxOnR397+c9VGNrqZlADbRByTnP5VO4LkGaZvxKv5ylNTb30PAqnXGWKlmBBSymzx/v0l0xEJwyHTHlegVZdyvS9wZfJDW4g88f6RpdCUNk4lTksb9zTv61E2bDQ+04gGNsNgxCVSlkx3MZ3LgnlX2WRY148qwVh2X0V4OEPSkxPS7ZM2o7yBYQNttsDnfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZB9YCdyr4gd3DjLpyKTOvWCVoHu/c6vKVVTe8xQzos=; b=IOVWgTIxroPxZPStwXbkZ1t2QkRquKov6/8g42J6p6+AigdMIr+TEyZlJ3GR+pqkAZTZsQoEtEzRbRaK54Iih6QkdZwO80KRFT4YpNYYkwTB/7KvFqcVq7JGrX2DZJh6+VBgFgWzaquvua2OKPK3+OfmLhS37iwpkw366f4852mNwUJeF3Nw0KmPr/tlqkTldn6DESt/Ohsono3jXYdcxfXjrf5oY5t5m9OJvlFaHhryGkCc9+K+XvTPuJ0ed/ZJoNusX40Xa6M1FwbkK9pEPkz56q2YKjlgC45QtgtMq8mWAUR/7UIbHuZGNexD+NTwX8GZgjRct8RtbP5grYnHUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sZB9YCdyr4gd3DjLpyKTOvWCVoHu/c6vKVVTe8xQzos=; b=BX8eLvy+89/R9N86WQAFpErUVJMp+2Gk/pL2XMd6n9Nqq7Jt2sMbL4XGyM21mwW8Y5hbxcEG40jOEfWukIeAPKdi5MRJu00gTlczTcHlH6t8JK/uun8AlbCR6ZmfwMAXERKERfpVB7GVJ2NXyzp0RSp0nUydZ+GKxxDPnWBwTcQ80hLrBV7wXdD4N303eh0gKWNQr4JkDw3L4AgGETNIi/JWhZrIdaI5wD0sgcZIjr4HePda9HSSeqKcn0IcWcXQgogj9i4E3cXfCWIs1HRAoAqQFxgSdA5YEvNrGHuIceCHbHoG7Z2m9iOFczOZvOTyi/S9fkA51U5h3RYr7STDqg== Received: from MW4P220CA0014.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::19) by CH3PR12MB8076.namprd12.prod.outlook.com (2603:10b6:610:127::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Wed, 1 Feb 2023 02:30:26 +0000 Received: from CO1NAM11FT080.eop-nam11.prod.protection.outlook.com (2603:10b6:303:115:cafe::cb) by MW4P220CA0014.outlook.office365.com (2603:10b6:303:115::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Wed, 1 Feb 2023 02:30:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT080.mail.protection.outlook.com (10.13.174.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Wed, 1 Feb 2023 02:30:26 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 18:30:14 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 18:30:14 -0800 Received: from NV-CL38DL3.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.36 via Frontend Transport; Tue, 31 Jan 2023 18:30:13 -0800 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [PATCH] RedfishPkg: fix multiple SMBIOS type 42 version issue Date: Wed, 1 Feb 2023 10:30:12 +0800 Message-ID: <20230201023012.122-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT080:EE_|CH3PR12MB8076:EE_ X-MS-Office365-Filtering-Correlation-Id: 71260189-379e-4f2c-899b-08db03fc4735 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jPTVfxEdDpK9uBS2vlyHPCxmU1JaHzuWrRSjBdSX0dedo40BCoMz67+z84yTTBD/UdpvZOnROuOqzomsa06INMGXonS9E/C1wvoIn1b5ci+eofpzoqfNUUshOjKzn3ZikVocMqQYu9M2h4/NwhgitIX/E5LZmeH50X1vokoEieS0B2eYHuvjTofLLsGZL0YMVo27CX7V0K8RxIi49ogG4GKU4okK8qbde9/vT3ADmeSIRCVv+nYqaZ2pvZFefW5UjBoTSOh7wABnXFRzd6zimSteQpKohzjBfXtq+9nsLdDgMtufxdFwIHRTu9tujl645UMGccWr6jGsfWHD26m2iI4gWmbKxd7+oZhxuLOldkODyHtMxu4Mgi9aIyco8PJEC9aJUeR7ae7IucT+Jr+2/GZ2+7BLHRF0eR7/2HqguJ2tyc1WXv3hw9TpsvQr6rnr4MFd62u8L8okUypGM2jwLpCBrRvgnvKgeAwXCTQeUDfdC322TTquAaSf3JgLCYI5Az6TT1qQr8+jPP16XAJg/+o7RE9w4V6vkWTD0EuzXzaYzg3mAgeMl0UhyA2B1QbECA2H4Ul3fLS02Q7Len1m06mbyt2HFsS8pArMOudnwdBdO/Pgzvf8wvXmFXnh0rFxsAGPJOaEgPuDUCP/86pjCB/Lnel8Gi1aJXPawuN58lhxXQ21uw2/V3xUgTpuByi8jVZc3w7iInvgvhYHgKv3iA== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199018)(40470700004)(46966006)(36840700001)(2906002)(82740400003)(36860700001)(19627235002)(54906003)(186003)(478600001)(316002)(26005)(36756003)(40480700001)(356005)(107886003)(41300700001)(86362001)(40460700003)(7636003)(82310400005)(4326008)(70206006)(8936002)(8676002)(2616005)(70586007)(1076003)(7696005)(6916009)(336012)(47076005)(426003)(83380400001)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 02:30:26.3452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71260189-379e-4f2c-899b-08db03fc4735 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT080.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8076 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain RedfishHostInterfaceDxe does not close protocol notify event in event callback function. This could cause multiple version of type 42 records issue if the protocol is installed more than once. Close the event in callback function so we only create one type 42 record. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 3e12e0c8b9..872cf3ae06 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -7,6 +7,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -260,6 +261,13 @@ PlatformHostInterfaceInformationReady ( DEBUG ((DEBUG_INFO, "%a: Platform Redfish Host Interface informtion is r= eady\n", __FUNCTION__)); =20 RedfishCreateSmbiosTable42 (); + + // + // Close event so we don't create multiple type 42 records + // + gBS->CloseEvent (Event); + mPlatformHostInterfaceReadylEvent =3D NULL; + return; } =20 --=20 2.39.1.windows.1