From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.85]) by mx.groups.io with SMTP id smtpd.web10.14631.1675220714662244493 for ; Tue, 31 Jan 2023 19:05:14 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=Aa0b+ZbW; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.220.85, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jjV8x8ARLZX0a5iyhqm718+wC7UfyXnMRGUFl7o929tU+2E6+hCpOccATla5O2kd7rT1Tcd8h/Kmxt7XWrXGF8FpEEIka8L4nkCQPWK2SOoWz1080SNI4oEIl0qJkXSuQXbiAdRsIQUmSmIh65rvCJUMD3kiEtzTWhSTFO6MDwIFzdhcKS/aH8cD0gAdh+rcwoXQV4WeUdCPJM6AKa33InxaYWe2/uChUxEo+IGpw+HqmEpGFY19g6M+h7SrI88gGfObUTycEBGRQqOVbwSQGe4b42gIpT+2cKzTdneD1HJoW8b/8MRIc2Gs6kSosuWentq4CJ6giSfKE/yMKBhI7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FnNuBzmFapqeaaTPVx5aw/mmJLoK4vQ1LEI1TJgoNhg=; b=ZhvpHHcaZwK5JllO7z3DNcex7NWTbymiyM5RVkV4ZYbPeP5++GANsfAz69kWyzp0Sxf9gfMTQ9uhZR4yJbcbS3zruOyMRiX3z5V66j/FQ+87/BcmtvkrxajD7qfsFFwtbTz25monwCavwoQQa7i4fg3NDQDXYS8YLrdX+n8WRXG1Xm4RTFtDXGi5xVit9UXrLMknibAwo3KpSpMrfsc/tJlVVnOghgPbEnO+uj13Mp6o1vPpdu2fLsSRzYeIrpRDz1mFJ5tkr9x0r22rgBnCyVIRiUiT/1dQh4wACOIVtE+iETztRSpu/frGYtD055dntOZQSd58znMbQM2z3ZgVSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FnNuBzmFapqeaaTPVx5aw/mmJLoK4vQ1LEI1TJgoNhg=; b=Aa0b+ZbWz1wKQByNX+DO5pNljFqnHmZ41Xlo+TA27JsOldMtChJ2D+2COkvP90RTBh04uuM/pFA1/s6L2wlRYmRYQo4c0b3KIHfIcOy0jctFbUbkRKBfMhNy6rgVE68kT2jisajdrjNeOmzeE7yvsi5/gMemYgDBZmkkLSJbxDwVi3ASzARCXAKMj9esMEyEvjUzyp4/ZXf49OlNqKe9qwGsNXTqwAgRqzYYXwECq9AWfl6Q8/b0tn8hVwtDWnSg+yVzspTY/Cg/bgKDrrGOXRD3gvSIgtQRNtIkb12aXDaBtns8Enrzdk47RmlOO6HbLcs/tiU54hQzdGOJQ2UkQw== Received: from DS7PR03CA0155.namprd03.prod.outlook.com (2603:10b6:5:3b2::10) by DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 03:05:12 +0000 Received: from DM6NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::2d) by DS7PR03CA0155.outlook.office365.com (2603:10b6:5:3b2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Wed, 1 Feb 2023 03:05:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by DM6NAM11FT024.mail.protection.outlook.com (10.13.172.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22 via Frontend Transport; Wed, 1 Feb 2023 03:05:12 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 19:05:05 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 19:05:04 -0800 Received: from NV-CL38DL3.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.36 via Frontend Transport; Tue, 31 Jan 2023 19:05:04 -0800 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [PATCH 1/2] RedfishPkg: fix config handler driver bug Date: Wed, 1 Feb 2023 11:05:03 +0800 Message-ID: <20230201030503.345-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT024:EE_|DM4PR12MB5312:EE_ X-MS-Office365-Filtering-Correlation-Id: cbda65ed-6bf0-4404-9b55-08db04012274 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rdNuN2FsHDj8trNz56Pv6QR17xxBWiUHPFlBBwFuhc3p12wbML09AlwRaUEZ/J66yxE16YmkL25B3ziiXpkYVN9fN5ds5qoFQPoj+vWuiZ1YLBqZi4Xk1r1RXMGIk50HkR+OMW4puTxP9AiigLk5AuYuF7/JRiTTGFC5ciwdbD++dWQQwyIbuGrw1bQKtc0++hfjKn3Se9Qz1BfW51tpmXIlfdUMNj7WoPBUNaDRQVAQkigJ88xBs366eZez6Li8/mnuRDUQfbaqhzQkkJ1bWBNBsJjeBMWVHnKPvmcQ38qpdANzt9NW90CCa7BiO9ubyhe0eH/qH95bKtxprFal1QNkr3AHpchkM1QMEU0es01Dv+nVEbKVNPCXd/cJxFhyXHE/Je4b4GB9/lQFh2RiVeXQUs8yeHBq49NrpObVjN38POyjkOZaFAClv3UD36zoUQv6goukCAo4rwZEGPzLru5HP9nYdZnRnelfkPx0/wa3QDNH3UCDg4n+aH6CGfzYwaHwlrgaYNuxvdiruKm02PEY06kpTjBcF5LGvX+yj/jt+rh0G8WL6sHbPDQoNX+u16iL/vtkqRtzDUnA7s5su58jwTz0tl8bhkOqlDdSRh8zSEWxjupTGIn4777tMUyongB4wsy3KyQDPypjIPUWfU9Egbl3Pb8Y5bGfzNFF3qwlS2eoQL6j5bfjjcuBbkbSWrHs3QjT3mhgWXRH6Q64/A== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199018)(36840700001)(40470700004)(46966006)(107886003)(1076003)(6916009)(478600001)(26005)(186003)(8676002)(4326008)(70586007)(70206006)(7696005)(7636003)(336012)(2616005)(47076005)(426003)(41300700001)(83380400001)(2906002)(40460700003)(8936002)(86362001)(82740400003)(36860700001)(82310400005)(36756003)(40480700001)(356005)(316002)(54906003)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 03:05:12.1196 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbda65ed-6bf0-4404-9b55-08db04012274 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5312 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Bug fix: - function stack fault - config handler driver requires the dependency of Redfish Credential Protocol - incorrect caller id installation when failed to perform init() Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishConfigHandler/RedfishConfigHandlerDriver.inf | 4 ++-- RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf= b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf index def91c7531..b167c6e1ee 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf @@ -4,6 +4,7 @@ # # Copyright (c) 2019, Intel Corporation. All rights reserved.
# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserve= d. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -56,5 +57,4 @@ gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event =20 [Depex] - TRUE - + gEdkIIRedfishCredentialProtocolGuid diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c index c3a7efd796..45276793c7 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c @@ -2,6 +2,7 @@ The common code of EDKII Redfish Configuration Handler driver. =20 (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -225,7 +226,7 @@ RedfishConfigHandlerInitialization ( UINTN NumberOfHandles; EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *ConfigHandler; UINTN Index; - UINT32 Id; + UINT32 *Id; =20 Status =3D gBS->LocateHandleBuffer ( ByProtocol, @@ -257,6 +258,7 @@ RedfishConfigHandlerInitialization ( Status =3D ConfigHandler->Init (ConfigHandler, &gRedfishConfigData.Red= fishServiceInfo); if (EFI_ERROR (Status) && (Status !=3D EFI_ALREADY_STARTED)) { DEBUG ((DEBUG_ERROR, "ERROR: Failed to init Redfish config handler %= p.\n", ConfigHandler)); + continue; } =20 // --=20 2.39.1.windows.1