public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging
Date: Wed, 1 Feb 2023 14:51:59 +0100	[thread overview]
Message-ID: <20230201135159.4jceyn7sepwesvup@sirius.home.kraxel.org> (raw)
In-Reply-To: <MN6PR11MB82446D4B145BEBE5E5C063FC8CD19@MN6PR11MB8244.namprd11.prod.outlook.com>

On Wed, Feb 01, 2023 at 05:25:18AM +0000, Ni, Ray wrote:
> Gerd,
> I saw Zhiguang and you had some conversation in V1 mail thread.
> Was below question answered in that conversation?

Yes (I missed the little detail the 5-level entry wasn't part of a page
table but just a single entry allocated at the stack, so without the fix
the stack gets corrupted).

> Any concern if I merge the patch?

No, v2 is fine.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd


      reply	other threads:[~2023-02-01 13:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  1:23 [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging Zhiguang Liu
2023-01-18  9:05 ` Gerd Hoffmann
2023-02-01  5:25   ` Ni, Ray
2023-02-01 13:51     ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230201135159.4jceyn7sepwesvup@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox