From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.23454.1675259524170488073 for ; Wed, 01 Feb 2023 05:52:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Sj/z70Ho; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675259523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YQ1jQuNtJg5pi7hQh30HOEd/wd+ySBOGDkykLhf3wvQ=; b=Sj/z70HoR3wPP4E12hCNb5K8Ym2cn1x2qV5HU+BzA6CJ+8/77fHTsbUoxLdTv7pJjXZzQ5 UmiDSncjU7Bt87mFGsbzxShKeXCwE0kYqq14CD4UKvkTkWDBqNV4otFiY51/1Z0xGTjGgj xa8KB3wqakwOfDr3k732xYgVHJxeqeA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-2qZha06iOaawNiGvPT3qQw-1; Wed, 01 Feb 2023 08:52:02 -0500 X-MC-Unique: 2qZha06iOaawNiGvPT3qQw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 79144100DEA2; Wed, 1 Feb 2023 13:52:01 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F7542166B33; Wed, 1 Feb 2023 13:52:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E52B818000A9; Wed, 1 Feb 2023 14:51:59 +0100 (CET) Date: Wed, 1 Feb 2023 14:51:59 +0100 From: "Gerd Hoffmann" To: "Ni, Ray" Cc: "Liu, Zhiguang" , "devel@edk2.groups.io" , "Kumar, Rahul R" , "Zeng, Star" , "Wu, Jiaxin" , "Dong, Eric" Subject: Re: [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging Message-ID: <20230201135159.4jceyn7sepwesvup@sirius.home.kraxel.org> References: <20230118012348.1195-1-zhiguang.liu@intel.com> <20230118090529.bwp4qpluagrpk53x@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 01, 2023 at 05:25:18AM +0000, Ni, Ray wrote: > Gerd, > I saw Zhiguang and you had some conversation in V1 mail thread. > Was below question answered in that conversation? Yes (I missed the little detail the 5-level entry wasn't part of a page table but just a single entry allocated at the stack, so without the fix the stack gets corrupted). > Any concern if I merge the patch? No, v2 is fine. Acked-by: Gerd Hoffmann take care, Gerd