From: "Savva Mitrofanov" <savvamtr@gmail.com>
To: devel@edk2.groups.io
Cc: "Marvin Häuser" <mhaeuser@posteo.de>,
"Pedro Falcato" <pedro.falcato@gmail.com>,
"Vitaly Cheptsov" <vit9696@protonmail.com>
Subject: [edk2-platforms][PATCH v4 00/12] Ext4Pkg: Code correctness and security improvements
Date: Thu, 2 Feb 2023 16:21:21 +0600 [thread overview]
Message-ID: <20230202102133.51606-1-savvamtr@gmail.com> (raw)
Hi all,
In v4 I rebased patches according upstream. Also in this revision I corrected
all remarks and comments from v3.
This patchset fixes several code problems found by fuzzing Ext4Dxe like
buffer and integer overflows, memory leaks, logic bugs and so on.
REF: https://github.com/savvamitrofanov/edk2-platforms/tree/master
Cc: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Savva Mitrofanov (12):
Ext4Pkg: Fix memory leak in Ext4RetrieveDirent
Ext4Pkg: Fix incorrect checksum metadata feature check
Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group
Ext4Pkg: Add inode number validity check
Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock
Ext4Pkg: Corrects integer overflow check logic in DiskUtil
Ext4Pkg: Check that source file is directory in Ext4OpenInternal
Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName
Ext4Pkg: Add missing exit Status in Ext4OpenDirent
Ext4Pkg: Fixes build on MSVC
Ext4Pkg: Filter out directory entry names containing \0 as invalid
Ext4Pkg: Corrects memory leak in Ext4ReadSlowSymlink
Features/Ext4Pkg/Ext4Pkg.dsc | 2 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 13 +++++-
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 26 ++++++++++++
Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 5 +++
Features/Ext4Pkg/Ext4Dxe/Directory.c | 42 ++++++++++++--------
Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 18 +++++++--
Features/Ext4Pkg/Ext4Dxe/Extents.c | 15 +++++--
Features/Ext4Pkg/Ext4Dxe/File.c | 23 ++++++++---
Features/Ext4Pkg/Ext4Dxe/Inode.c | 6 +--
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++++--
Features/Ext4Pkg/Ext4Dxe/Symlink.c | 13 +++---
11 files changed, 134 insertions(+), 45 deletions(-)
--
2.39.1
next reply other threads:[~2023-02-02 10:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 10:21 Savva Mitrofanov [this message]
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 01/12] Ext4Pkg: Fix memory leak in Ext4RetrieveDirent Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 02/12] Ext4Pkg: Fix incorrect checksum metadata feature check Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 03/12] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 04/12] Ext4Pkg: Add inode number validity check Savva Mitrofanov
2023-02-02 10:32 ` Marvin Häuser
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 05/12] Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 06/12] Ext4Pkg: Corrects integer overflow check logic in DiskUtil Savva Mitrofanov
2023-02-02 10:31 ` Marvin Häuser
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 07/12] Ext4Pkg: Check that source file is directory in Ext4OpenInternal Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 08/12] Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 09/12] Ext4Pkg: Add missing exit Status in Ext4OpenDirent Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 10/12] Ext4Pkg: Fixes build on MSVC Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 11/12] Ext4Pkg: Filter out directory entry names containing \0 as invalid Savva Mitrofanov
2023-02-02 10:30 ` Marvin Häuser
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 12/12] Ext4Pkg: Corrects memory leak in Ext4ReadSlowSymlink Savva Mitrofanov
2023-02-02 10:29 ` Marvin Häuser
2023-02-08 16:32 ` [edk2-platforms][PATCH v4 00/12] Ext4Pkg: Code correctness and security improvements Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202102133.51606-1-savvamtr@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox