From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mx.groups.io with SMTP id smtpd.web10.11492.1675333308245637613 for ; Thu, 02 Feb 2023 02:21:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=g1ZO/Jo1; spf=pass (domain: gmail.com, ip: 209.85.218.53, mailfrom: savvamtr@gmail.com) Received: by mail-ej1-f53.google.com with SMTP id k4so4622209eje.1 for ; Thu, 02 Feb 2023 02:21:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4bDzYgnYyDQti0jM78896hPUaRPq4PN5vpS720IRz/w=; b=g1ZO/Jo1DXGziEyKqJeugI5/yZwDTYbqqKkwuuRCwy7Oy3ujox4y77N7EGJ5boJawE x8aN4Styclpl1rt11Wen5oaqwb0wrbtjvk4dI0PRz4zfoWKkRTZsMLBJoF7R3t1hb4LX tAzTXaKh0LJ09Ntd8m5Kgx6HyxxNB5OclY5Su1gFlwPTi/nv2qImNKdg8PqTep5D6Xwy gJl0DgyYUPBzU4gj42nIGJFNUsEDZkAlhktQIGcKFTOtLF8utPed30kf1GJVMwqEgzlb 4brwHhM+8DM+m5eli35fAgrMpbdMNZQG7Lj0Xa0bk99MvU0giDf+ZF0wNJ6b+hyFkphG 0FEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4bDzYgnYyDQti0jM78896hPUaRPq4PN5vpS720IRz/w=; b=qhsxFr9hYravA9o/da6VR6zaqeDU8SEY87AWpp2nHb5UJuoa9DEQuCTnY3c3d2dcyN ff3X0XX14vEauB8X2rvu3PX9Fg3+SNzdDLoPKIBh65aVvhwxmN1X6R81/nM+pR3DwRHz oBaQKXh0E4TN46pDKxn8TymKmeGrXiBylrZ6EsKf5M4onQk1odW1wVsjBj0uezxeal+A T8LimNBSfLFEYfPulmIQMBRlcC+55j7VlNGG0nb+6neQiPCa5hbs+PJNY/TacZ9oWbBc KX/VUfarzp+5N48EfwxhyfV6imkfHWaC7pLfw8X7NHJZGZ6sMz6gPcDAYHidHzG8vrHs aZ4w== X-Gm-Message-State: AO0yUKVAAzIPwJWe6o1hKU3/I/Qh6x/gIRS5wEJweTrZrsnEipVfQ71h EXijZ5/Pp1DaV0o9yEHFvqhNboj7nlguKw== X-Google-Smtp-Source: AK7set9q3GKw/DHpEH0PRL2CkWszUtMaKeZWshdoSND+OV1SipXQ9iDkrkfzqvANTWTqThkKLyMcpQ== X-Received: by 2002:a17:906:5ac7:b0:882:1b70:8962 with SMTP id x7-20020a1709065ac700b008821b708962mr5492645ejs.76.1675333306640; Thu, 02 Feb 2023 02:21:46 -0800 (PST) Return-Path: Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id ci22-20020a170906c35600b0087bcda2b07bsm10013121ejb.202.2023.02.02.02.21.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Feb 2023 02:21:46 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v4 09/12] Ext4Pkg: Add missing exit Status in Ext4OpenDirent Date: Thu, 2 Feb 2023 16:21:30 +0600 Message-Id: <20230202102133.51606-10-savvamtr@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> References: <20230202102133.51606-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Missing EFI_OUT_OF_RESOURCES exit status on failed Ext4CreateDentry leads to NULL-pointer dereference in Ext4GetFileInfo (passing NULL buffer in Ext4ReadDir) Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: 21b1853880d5 ("Ext4Pkg: Add a directory entry tree.") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin H=C3=A4user --- Features/Ext4Pkg/Ext4Dxe/Directory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4Dx= e/Directory.c index c7992cc72717..dee8cfc66cb7 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c @@ -267,7 +267,8 @@ Ext4OpenDirent ( } else {=0D File->Dentry =3D Ext4CreateDentry (FileName, Directory->Dentry);=0D =0D - if (!File->Dentry) {=0D + if (File->Dentry =3D=3D NULL) {=0D + Status =3D EFI_OUT_OF_RESOURCES;=0D goto Error;=0D }=0D }=0D --=20 2.39.1