From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mx.groups.io with SMTP id smtpd.web11.11513.1675333309306946478 for ; Thu, 02 Feb 2023 02:21:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oSFad0eo; spf=pass (domain: gmail.com, ip: 209.85.218.41, mailfrom: savvamtr@gmail.com) Received: by mail-ej1-f41.google.com with SMTP id k4so4622311eje.1 for ; Thu, 02 Feb 2023 02:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+fjQ1aaoQQfp2E+YlMGxgY6BtXWhWTj0tdU10sxNSPA=; b=oSFad0eo7utVe7RKqPoJ+zHqBbp/QiuKSMrSOI7HFmRox1lJJw94ur3SOUPSCTRkJO xplyQA+2mn0ePjNMKwatW3KMPVs/YMIWDPF5FteIK++ffLCqY57BFKAuzpKS3Mf2BywN 6H/AjB70ZD0iGEgyDJ+baEsFrW9rqSX94w4iw722kmTZABijmnSPUit6zilEltnmVz1f jt3NT0oPAX1iWgpC1UHGGtuiLawRI27G/XEytu6exWjWsxpk8oxBDUvC51FLtB7+tLfd 4cXSc1w45ByY7D8DrylMPT5DZ3mBx4iZ3GGl2xJywmvkBxxrpwhj7oCQ/kDk0lsfwa/O sdqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fjQ1aaoQQfp2E+YlMGxgY6BtXWhWTj0tdU10sxNSPA=; b=G2YZzkjZ5dy9/4lUcjqTvXC3C+pg8k/H2M9hfgPn1/0XEfMzL5796mY4f9A8klZgsX Svibfu5I4wkzOGNqX74+k1aZcmYnVG4BbJNU3epB6FZZXZ9PjhaNwDGOmO4jJKy1dH1v mzjx0bPWADHsZYLulvlmitTCuCNd+i5mwSDg1GWSw56q3PYNq/OAn+GVWF8/4hebQEHg RZ9sauTP7CMq9dtfCeWN3/YK5BOmR2Tde3APiIhqIrWq52bmTZnm9zzEBugYL6bjZMz/ Pye9XBO3b58YqNN+QZYaSAJGcP8RTYiMDGSqbQUzzXpUCu8Obi/Sj4J60vIOGTKUbFRz wCbw== X-Gm-Message-State: AO0yUKU4fm72h3zWAz8mWD4q3aFtwb5cZ1hF8bPZSkoX4YIrJLES/2tD +NSvKUqEk/oZ3R3sUKAyvklkuDt2s2MV/g== X-Google-Smtp-Source: AK7set+hcJWdCBCesW2wxt9E+xkKUe9kQHFwzc2j9wxUiFwPoDtEhanrC33yuO968MGDfjE3j+9t/Q== X-Received: by 2002:a17:906:684c:b0:877:a2d1:7560 with SMTP id a12-20020a170906684c00b00877a2d17560mr5068276ejs.27.1675333307675; Thu, 02 Feb 2023 02:21:47 -0800 (PST) Return-Path: Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id ci22-20020a170906c35600b0087bcda2b07bsm10013121ejb.202.2023.02.02.02.21.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Feb 2023 02:21:47 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v4 10/12] Ext4Pkg: Fixes build on MSVC Date: Thu, 2 Feb 2023 16:21:31 +0600 Message-Id: <20230202102133.51606-11-savvamtr@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> References: <20230202102133.51606-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Accessing array using index of uint64 type makes MSVC compiler to include `__allmul` function in NOOPT which is not referenced in IA32. So we null-terminates string using ReadSize, which should be equal to SymlinkSizeTmp after correct reading. Also adds missing MultU64x32 in Ext4Read. Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: 7c46116b0e18 ("Ext4Pkg: Add ext2/3 support") Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin H=C3=A4user --- Features/Ext4Pkg/Ext4Dxe/Inode.c | 4 ++-- Features/Ext4Pkg/Ext4Dxe/Symlink.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Inode.c b/Features/Ext4Pkg/Ext4Dxe/In= ode.c index 90e3eb88f523..8db051d3c444 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Inode.c +++ b/Features/Ext4Pkg/Ext4Dxe/Inode.c @@ -152,7 +152,7 @@ Ext4Read ( } else {=0D // Uninitialized extents behave exactly the same as file holes, ex= cept they have=0D // blocks already allocated to them.=0D - HoleLen =3D (Ext4GetExtentLength (&Extent) * Partition->BlockSize)= - HoleOff;=0D + HoleLen =3D MultU64x32 (Ext4GetExtentLength (&Extent), Partition->= BlockSize) - HoleOff;=0D }=0D =0D WasRead =3D HoleLen > RemainingRead ? RemainingRead : (UINTN)HoleLen= ;=0D @@ -166,7 +166,7 @@ Ext4Read ( Partition->BlockSize=0D );=0D ExtentLengthBytes =3D Extent.ee_len * Partition->BlockSize;=0D - ExtentLogicalBytes =3D (UINT64)Extent.ee_block * Partition->BlockSiz= e;=0D + ExtentLogicalBytes =3D MultU64x32 ((UINT64)Extent.ee_block, Partitio= n->BlockSize);=0D ExtentOffset =3D CurrentSeek - ExtentLogicalBytes;=0D ExtentMayRead =3D (UINTN)(ExtentLengthBytes - ExtentOffset);=0D =0D diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe/= Symlink.c index 19b357ac6ba0..8b1511a38b55 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c @@ -1,7 +1,7 @@ /** @file=0D Symbolic links routines=0D =0D - Copyright (c) 2022 Savva Mitrofanov All rights reserved.=0D + Copyright (c) 2022-2023 Savva Mitrofanov All rights reserved.=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D **/=0D =0D @@ -155,11 +155,6 @@ Ext4ReadSlowSymlink ( return Status;=0D }=0D =0D - //=0D - // Add null-terminator=0D - //=0D - SymlinkTmp[SymlinkSizeTmp] =3D '\0';=0D -=0D if (SymlinkSizeTmp !=3D ReadSize) {=0D DEBUG ((=0D DEBUG_FS,=0D @@ -168,6 +163,11 @@ Ext4ReadSlowSymlink ( return EFI_VOLUME_CORRUPTED;=0D }=0D =0D + //=0D + // Add null-terminator=0D + //=0D + SymlinkTmp[ReadSize] =3D '\0';=0D +=0D *AsciiSymlinkSize =3D SymlinkAllocateSize;=0D *AsciiSymlink =3D SymlinkTmp;=0D =0D --=20 2.39.1