public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Savva Mitrofanov" <savvamtr@gmail.com>
To: devel@edk2.groups.io
Cc: "Marvin Häuser" <mhaeuser@posteo.de>,
	"Pedro Falcato" <pedro.falcato@gmail.com>,
	"Vitaly Cheptsov" <vit9696@protonmail.com>
Subject: [edk2-platforms][PATCH v4 12/12] Ext4Pkg: Corrects memory leak in Ext4ReadSlowSymlink
Date: Thu,  2 Feb 2023 16:21:33 +0600	[thread overview]
Message-ID: <20230202102133.51606-13-savvamtr@gmail.com> (raw)
In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com>

We need to free SymlinkTmp before exiting if SymlinkSizeTmp != ReadSize
condition is true

Reported-by: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support")
Signed-off-by: Savva Mitrofanov <savvamtr@gmail.com>
Reviewed-by: Marvin Häuser <mhaeuser@posteo.de>
---
 Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
index 8b1511a38b55..1189a99ded2b 100644
--- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c
+++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
@@ -160,6 +160,7 @@ Ext4ReadSlowSymlink (
       DEBUG_FS,
       "[ext4] Error! The size of the read block doesn't match the value from the inode!\n"
       ));
+    FreePool (SymlinkTmp);
     return EFI_VOLUME_CORRUPTED;
   }
 
-- 
2.39.1


  parent reply	other threads:[~2023-02-02 10:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 10:21 [edk2-platforms][PATCH v4 00/12] Ext4Pkg: Code correctness and security improvements Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 01/12] Ext4Pkg: Fix memory leak in Ext4RetrieveDirent Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 02/12] Ext4Pkg: Fix incorrect checksum metadata feature check Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 03/12] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 04/12] Ext4Pkg: Add inode number validity check Savva Mitrofanov
2023-02-02 10:32   ` Marvin Häuser
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 05/12] Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 06/12] Ext4Pkg: Corrects integer overflow check logic in DiskUtil Savva Mitrofanov
2023-02-02 10:31   ` Marvin Häuser
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 07/12] Ext4Pkg: Check that source file is directory in Ext4OpenInternal Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 08/12] Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 09/12] Ext4Pkg: Add missing exit Status in Ext4OpenDirent Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 10/12] Ext4Pkg: Fixes build on MSVC Savva Mitrofanov
2023-02-02 10:21 ` [edk2-platforms][PATCH v4 11/12] Ext4Pkg: Filter out directory entry names containing \0 as invalid Savva Mitrofanov
2023-02-02 10:30   ` Marvin Häuser
2023-02-02 10:21 ` Savva Mitrofanov [this message]
2023-02-02 10:29   ` [edk2-platforms][PATCH v4 12/12] Ext4Pkg: Corrects memory leak in Ext4ReadSlowSymlink Marvin Häuser
2023-02-08 16:32 ` [edk2-platforms][PATCH v4 00/12] Ext4Pkg: Code correctness and security improvements Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230202102133.51606-13-savvamtr@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox