From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mx.groups.io with SMTP id smtpd.web10.11489.1675333302793373515 for ; Thu, 02 Feb 2023 02:21:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lRkymYF4; spf=pass (domain: gmail.com, ip: 209.85.218.54, mailfrom: savvamtr@gmail.com) Received: by mail-ej1-f54.google.com with SMTP id lu11so4594916ejb.3 for ; Thu, 02 Feb 2023 02:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rj9wiD6Yv2mSYC0ku/otDFA8V2N2cBB1R4FHvP19mcA=; b=lRkymYF4SugWg3QsXj7RXrc/+gTf/NOEu3xzRfdWtW7WcaQ1IjcCvrM/P6l2qlNto1 rD0SWEOl9JfHnj/gtWrBV594pgOPDf7tR6tknYRKr0l8W3cKgqL0oJ3MsT595B8KiI87 sEc44vKlBgpPoZHVQP61ZHlqs+LcjL+voWc9vBNbIkozRYdb+QIZdDIqotm6LkklWK7p FQ1hV/rVKaQKiTq+56/HKSBHoJYG2GrlTd3tPMRw3OKNEM3QRxikiF+P1v8AOrNaE8hg f0bWILkOIIvBRi+Rb9aslPCzJ8UiEHzWCoo4RM6P5rvGuJTgqUa408Limpf4dVT3NtmN ShmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rj9wiD6Yv2mSYC0ku/otDFA8V2N2cBB1R4FHvP19mcA=; b=WGz+h6smF3waof949BHrwsNKdYjP5VjFjo8aRwNWbhkL48KjxTgqdPc3r5gMi3Y6Gz YcUANmsZXtSFkKgsFaoQZew3ea5bQlRV/8N2pyZkfjA2KkRfExeMK9mzLgSQmHJao6RU 9UTcrBBUbac3FlskEiTZ++FhP3Te/u2PjGtSQNViknFIvd5smWL4Dp/Jf50GpIx0NRtT 9umfWtAXycgRn6kngFhtr2BZz9GtKDGbQja1Bd3ALLiWqtLmox1WRqy5lwsMd5eGfKTm DkyDLf0dJIdzYq87DKy3TCe2bOSduP4/EJPGpILaEpLIItC1pXAXyZVHRg6yYooLt9Yv 3gJA== X-Gm-Message-State: AO0yUKVoMu9q99JHmW80OvTxY64JhdG3jpvYhun1WGC1O9DvKF1for7a j3CsySM2zmNVdFI3NOn1RGWoKkX4hg5Rmg== X-Google-Smtp-Source: AK7set8Mr2wZ/I6OmRuQl54egMPfoGhRovmHU/YGkTSDXk0q4jb7s50vNj4olcNJC5bg7EMdHM+dkA== X-Received: by 2002:a17:906:5945:b0:888:787d:2064 with SMTP id g5-20020a170906594500b00888787d2064mr5722453ejr.75.1675333309795; Thu, 02 Feb 2023 02:21:49 -0800 (PST) Return-Path: Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id ci22-20020a170906c35600b0087bcda2b07bsm10013121ejb.202.2023.02.02.02.21.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Feb 2023 02:21:49 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v4 12/12] Ext4Pkg: Corrects memory leak in Ext4ReadSlowSymlink Date: Thu, 2 Feb 2023 16:21:33 +0600 Message-Id: <20230202102133.51606-13-savvamtr@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> References: <20230202102133.51606-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable We need to free SymlinkTmp before exiting if SymlinkSizeTmp !=3D ReadSize condition is true Reported-by: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin H=C3=A4user --- Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe/= Symlink.c index 8b1511a38b55..1189a99ded2b 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c @@ -160,6 +160,7 @@ Ext4ReadSlowSymlink ( DEBUG_FS,=0D "[ext4] Error! The size of the read block doesn't match the value fr= om the inode!\n"=0D ));=0D + FreePool (SymlinkTmp);=0D return EFI_VOLUME_CORRUPTED;=0D }=0D =0D --=20 2.39.1