From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mx.groups.io with SMTP id smtpd.web10.11488.1675333301816810625 for ; Thu, 02 Feb 2023 02:21:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=W89N08/c; spf=pass (domain: gmail.com, ip: 209.85.208.41, mailfrom: savvamtr@gmail.com) Received: by mail-ed1-f41.google.com with SMTP id eq11so1466605edb.6 for ; Thu, 02 Feb 2023 02:21:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JUrGjXmZuSPisNwlKIE8F90HVsjW8NvZV/FynzowIVE=; b=W89N08/cqnDRFBNsCjBcRrsPO97TNr1YLdznAakqqhjwvGDK2mBNPK1rNK1s+utc4Y Llu3Qj1zBjWwv2KkXpgG5t7+Bs+RYA4QGpnj+wL4slrYmSqQPNGmZ6YrtpE3QY/Z9nz5 hBAGEUP7HyqG8egvoBl7kkQqZz8tmI0GRaCnumE3DhO6x36+IyN9N5hfTvmC4r86DG/P cAWhzgNqXEOMK3qPEmodOHRrFErfkKtNogEcehtI57OW37Czq2AszB0g0VB0m0MInkCT 2xLU7S6NEEulw1pzAAOtwOEckhyZz+Yqr6Nx1D0vGWi3DivgTM5/XYw5hUg3T7dYKXoJ Iwpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JUrGjXmZuSPisNwlKIE8F90HVsjW8NvZV/FynzowIVE=; b=SIofhIxcm0OBSKIPRCViWwPrlyuKT/BpnhmTcvo9KPZ9Z+sNlFSA+RlZsw5iz1AW+E O6gb3Mru6csSBRtcSWCMbq531stHeaor0RUMDiWuBEJxqFfzAC9vChtf5oVz3P15OMeT +UHV4Vjl7R1D97jB63WDtOJ05IESgl2qmTypAEU1+1aGjgokjRtJRRpjnFKNF2xrCQ0+ /sQeWfyObRChW+qQmE/YpzXaFBLCQJRv2L4k4tyoGAb+rNEWrRXZQ/cFGIhe9d/SFGmP VxFLSJvGW8BEEx1ZtTPxQP9oX/hngVo0Tgb4Zz7Fevg8vZMBDIaK34dczc/i2k74Blss qs6w== X-Gm-Message-State: AO0yUKVG9QtZLWVm4Y27B4Gs/QyeoiCFTXAjSh4KRAb1y6tjderNtNE7 PC+0M6vrVuzo6qoOJTXUPJi+7nekM+0wPA== X-Google-Smtp-Source: AK7set+TImjv2BidbYL25VRFK7NI0t3SjyyEJ0GvqxBoz3liDkGX7baamApUn83WNYJ/E3dLxfdhPw== X-Received: by 2002:aa7:d481:0:b0:4a2:1618:d702 with SMTP id b1-20020aa7d481000000b004a21618d702mr5607537edr.18.1675333300129; Thu, 02 Feb 2023 02:21:40 -0800 (PST) Return-Path: Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id ci22-20020a170906c35600b0087bcda2b07bsm10013121ejb.202.2023.02.02.02.21.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Feb 2023 02:21:39 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v4 03/12] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Date: Thu, 2 Feb 2023 16:21:24 +0600 Message-Id: <20230202102133.51606-4-savvamtr@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> References: <20230202102133.51606-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Superblock s_inodes_per_group field can't be zero, it leads to division by zero in BlockGroup routine Ext4ReadInode Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin H=C3=A4user --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 35dcf3c007c8..be3527e4d618 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -243,6 +243,11 @@ Ext4OpenSuperblock ( =0D DEBUG ((DEBUG_FS, "Read only =3D %u\n", Partition->ReadOnly));=0D =0D + if (Sb->s_inodes_per_group =3D=3D 0) {=0D + DEBUG ((DEBUG_ERROR, "[ext4] Inodes per group can not be zero\n"));=0D + return EFI_VOLUME_CORRUPTED;=0D + }=0D +=0D Partition->BlockSize =3D (UINT32)LShiftU64 (1024, Sb->s_log_block_size);= =0D =0D // The size of a block group can also be calculated as 8 * Partition->Bl= ockSize=0D --=20 2.39.1