From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.13625.1675342465825611149 for ; Thu, 02 Feb 2023 04:54:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F5XfEU9S; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675342464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ilWt+7idKUh/E4MpzNNa3Tll53xMpvm0jQDmnlh89Q=; b=F5XfEU9SgdrddWGjVsP48OUsa8dsm9tMGWEqCfyDewREyIcOlVM/8x8T9HGB59rG+I/Oz5 4fRXFaBFegdF2Okc6ye+OBXKzRPwI9X+BpHHoMUH6A0hQB64YA95YGYec9cu+hujI53RAJ UHqXBPtio0WKJc8BV7dcbc19Zpij4y0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-pEtgPhmoPPCysWWLI9b_Hw-1; Thu, 02 Feb 2023 07:54:19 -0500 X-MC-Unique: pEtgPhmoPPCysWWLI9b_Hw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 03D7838173C1; Thu, 2 Feb 2023 12:54:19 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA7C52166B33; Thu, 2 Feb 2023 12:54:18 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6F815180061A; Thu, 2 Feb 2023 13:54:17 +0100 (CET) Date: Thu, 2 Feb 2023 13:54:17 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Michael Roth Subject: Re: [PATCH V5 03/13] OvmfPkg/IntelTdx: Add SecTdxHelperLib Message-ID: <20230202125417.j2is6rb7whokpfup@sirius.home.kraxel.org> References: <20230128135842.980-1-min.m.xu@intel.com> <20230128135842.980-4-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <20230128135842.980-4-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 28, 2023 at 09:58:32PM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 > > TdxHelperLib provides below helper functions for a td-guest. > - TdxHelperProcessTdHob > - TdxHelperMeasureTdHob > - TdxHelperMeasureCfvImage > - TdxHelperBuildGuidHobForTdxMeasurement > > SecTdxHelperLib is the SEC instance of TdxHelperLib. It implements 4 > functions for tdx in SEC phase: > - TdxHelperProcessTdHob consumes TdHob to accept un-accepted memories. > Before the TdHob is consumed, it is first validated. > > - TdxHelperMeasureTdHob measure/extend TdHob and store the measurement > value in workarea. > > - TdxHelperMeasureCfvImage measure/extend the Configuration FV image and > store the measurement value in workarea. > > - TdxHelperBuildGuidHobForTdxMeasurement builds GuidHob for tdx > measurement. > > This patch implements the stubs of the functions. The actual > implementations are in the following patches. Because they are moved from > other files. > > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Tom Lendacky > Cc: Michael Roth > Signed-off-by: Min Xu Acked-by: Gerd Hoffmann