From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.13974.1675343380555198612
 for <devel@edk2.groups.io>;
 Thu, 02 Feb 2023 05:09:40 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TYL3TM3M;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1675343379;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Ku8ARyVNqIz1qt2jtgp+VmOngFPcRN4+L5vPV546lPA=;
	b=TYL3TM3MijTq3GO75637jRdmxoWMTOaNvnxxOvnFfmwP8lLMjqkpLjvgJQiAIwxkBAXozr
	KtgOMja7Z/xMspxrB0acZlipJW9TcyUwBhkLpSqLaNknA9krMrpRBE1Ja3K2O/a9OqDiWO
	3IlvDIC7JTZQBqcL7Xq01UVWfquKuc4=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-99-KYxOSpaFMrS2j7Qn7XbvqA-1; Thu, 02 Feb 2023 08:09:36 -0500
X-MC-Unique: KYxOSpaFMrS2j7Qn7XbvqA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D72BD811E9C;
	Thu,  2 Feb 2023 13:09:35 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.85])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A1846112132C;
	Thu,  2 Feb 2023 13:09:35 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id F32C1180061A; Thu,  2 Feb 2023 14:09:33 +0100 (CET)
Date: Thu, 2 Feb 2023 14:09:33 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V5 06/13] OvmfPkg: Refactor MeaureFvImage
Message-ID: <20230202130933.f7iuk2d4hs6dkbs4@sirius.home.kraxel.org>
References: <20230128135842.980-1-min.m.xu@intel.com>
 <20230128135842.980-7-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230128135842.980-7-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jan 28, 2023 at 09:58:35PM +0800, Min Xu wrote:
> From: Min M Xu <min.m.xu@intel.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
> 
> MeasureFvImage once was implemented in PeilessStartupLib and it does
> measurement and logging for Configuration FV (Cfv) image in one go,
> using TpmMeasureAndLogData(). But it doesn't work in SEC.
> 
> This patch splits MeasureFvImage into 2 functions and implement them in
> SecTdxHelperLib.
>  - TdxHelperMeasureCfvImage
>  - TdxHelperBuildGuidHobForTdxMeasurement
> 
> TdxHelperMeasureCfvImage measures the Cfv image and stores the hash value
> in WorkArea. TdxHelperBuildGuidHobForTdxMeasurement builds GuidHob for the
> measurement based on the hash value in WorkArea.
> 
> After these 2 functions are introduced, PeilessStartupLib should also be
> updated:
>  - Call these 2 functions instead of the MeasureFvImage
>  - Delete the duplicated codes in PeilessStartupLib

Acked-by: Gerd Hoffmann <kraxel@redhat.com>