From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.14056.1675343760696772077
 for <devel@edk2.groups.io>;
 Thu, 02 Feb 2023 05:16:00 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cImkXOvP;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1675343759;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=lhaCAoEvid27+/1FPbUQDLYSw2AprcEdgbj+5bGVk/Y=;
	b=cImkXOvPSatSljVqEeha6PvQOeas7ylF1Bx/5mhFnZ06or8q8+FXEQ0anLleAuzir84X17
	Ogc77QWKzkwNrjhZhMz6/cBm3cSWaicu0lD5ZoUYAkJtRVNBW3IbkulLgx2Sbdorn2Wr5j
	7j6r23yCODCDBcLSmDM0MBNNzMUSdC8=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-417-QHknprtdMz-7AE7FFyRoow-1; Thu, 02 Feb 2023 08:15:58 -0500
X-MC-Unique: QHknprtdMz-7AE7FFyRoow-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDD1A3848C27;
	Thu,  2 Feb 2023 13:15:57 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.85])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id C295B112132C;
	Thu,  2 Feb 2023 13:15:57 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 938CB180061A; Thu,  2 Feb 2023 14:15:56 +0100 (CET)
Date: Thu, 2 Feb 2023 14:15:56 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V5 13/13] OvmfPkg: Support Tdx measurement in OvmfPkgX64
Message-ID: <20230202131556.tzmlpjp66nsgen2n@sirius.home.kraxel.org>
References: <20230128135842.980-1-min.m.xu@intel.com>
 <20230128135842.980-14-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230128135842.980-14-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jan 28, 2023 at 09:58:42PM +0800, Min Xu wrote:
> From: Min M Xu <min.m.xu@intel.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
> 
> This patch enables Tdx measurement in OvmfPkgX64 with below changes:
> 1) TDX_MEASUREMENT_ENABLE is introduced in OvmfPkgX64.dsc. This flag
>    indicates if Intel TDX measurement is enabled in OvmfPkgX64. Its
>    default value is FALSE.
> 2) Include TdTcg2Dxe in OvmfPkgX64 so that CC_MEASUREMENT_PROTOCOL
>    is installed in a Td-guest. TdTcg2Dxe is controlled by
>    TDX_MEASUREMENT_ENABLE because it is only valid when Intel TDX
>    measurement is enabled.
> 3) OvmfTpmLibs.dsc.inc and OvmfTpmSecurityStub.dsc.inc are updated
>    because DxeTpm2MeasureBootLib.inf and DxeTpmMeasurementLib.inf
>    should be included to support CC_MEASUREMENT_PROTOCOL.
> 
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>