From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.5261.1675405847292207197 for ; Thu, 02 Feb 2023 22:30:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bJmGOOJ6; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675405845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/T+FOGaUgMYiwdghkE72SQm2ipIBJpVVEWEdhkiJIy8=; b=bJmGOOJ6Bto8+mwNLxenlhBT6mLsLR+vKNmMK63w/5yf2NG3zgU2n1J9DnRg3GaQdz86QX jzDKep+Q3v9fxdU2VdleBdHrYS1GpYtkw/5RVgGkcJ7GdmiV8DGyHEdQUcHYHAJmCCj1Gf K4ZrEH4Fu/p+47f+wVUtm+xsto6uRpo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-i2vmoSnGPMitI6jiIXmDig-1; Fri, 03 Feb 2023 01:30:40 -0500 X-MC-Unique: i2vmoSnGPMitI6jiIXmDig-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DAC8785A5A3; Fri, 3 Feb 2023 06:30:38 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 897252166B34; Fri, 3 Feb 2023 06:30:38 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A2AA5180060E; Fri, 3 Feb 2023 07:30:35 +0100 (CET) Date: Fri, 3 Feb 2023 07:30:35 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Michael Roth Subject: Re: [PATCH V3 1/1] OvmfPkg/AcpiPlatformDxe: Measure ACPI table from QEMU in TDVF Message-ID: <20230203063035.yygmjhvmtvw434y6@sirius.home.kraxel.org> References: <20230202090314.336-1-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <20230202090314.336-1-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 02, 2023 at 05:03:14PM +0800, Min Xu wrote: > From: Min M Xu > > https://bugzilla.tianocore.org/show_bug.cgi?id=4245 > > QEMU provides the following three files for guest to install the ACPI > tables: > - etc/acpi/rsdp > - etc/acpi/tables > - etc/table-loader > > "etc/acpi/rsdp" and "etc/acpi/tables" are similar, they are only kept > separate because they have different allocation requirements in SeaBIOS. > > Both of these fw_cfg files contain preformatted ACPI payload. > "etc/acpi/rsdp" contains only the RSDP table, while "etc/acpi/tables" > contains all other tables, concatenated. To be noted, the tables in these > two files have been filled in by qemu, but two kinds of fields are > incomplete: pointers to other tables and checksums (which depend on the > pointers). > > "/etc/table-loader" is a linker/loader which provides the commands to > "patch" the tables in "etc/acpi/tables" and then install them. "Patch" > means to fill the pointers and compute the checksum. > > From the security perspective these 3 files are the raw data downloaded > from qemu. They should be measured and extended before they're consumed. > > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Tom Lendacky > Cc: Michael Roth > Signed-off-by: Min Xu Acked-by: Gerd Hoffmann