From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.6563.1675415105693250668
 for <devel@edk2.groups.io>;
 Fri, 03 Feb 2023 01:05:05 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Dti+jzy6;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1675415104;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RphOI248lmqRRzX5DQPqKOhcsNPdkJ5VfmUpcpW7xHA=;
	b=Dti+jzy6MaoVYbJhhIMAV2jBlB3DMyJrBtE35NdcHhw9gpjpTflIetlvNNxjWhKq/iS5Es
	s8C1GmWPnqOzUDWk2NRzzj3fvcflNLfYiof3YJ/qtGVMBGxjC1h078m9yMWo7XBm0twiA2
	ww8w94A/mYTm9Z9RNaYFChAFxoaHjyU=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-629-JoT1-Qc1MJOZr6WkB381Kw-1; Fri, 03 Feb 2023 04:05:00 -0500
X-MC-Unique: JoT1-Qc1MJOZr6WkB381Kw-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4161857A81;
	Fri,  3 Feb 2023 09:04:59 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.85])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D4462166B34;
	Fri,  3 Feb 2023 09:04:59 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 22945180060E; Fri,  3 Feb 2023 10:04:58 +0100 (CET)
Date: Fri, 3 Feb 2023 10:04:58 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, jiaxin.wu@intel.com
Cc: "Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration
Message-ID: <20230203090458.eel4znipaxggfboa@sirius.home.kraxel.org>
References: <20230118095620.9860-1-jiaxin.wu@intel.com>
 <173B5EAF72B992BD.14781@groups.io>
 <MN0PR11MB61583AA809F07EA3CBEFCE5CFED79@MN0PR11MB6158.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <MN0PR11MB61583AA809F07EA3CBEFCE5CFED79@MN0PR11MB6158.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 03, 2023 at 08:59:06AM +0000, Wu, Jiaxin wrote:
> Hi Laszlo & Gerd,
> 
> >  SmmCpuFeaturesLibConstructor (
> >    IN EFI_HANDLE        ImageHandle,
> >    IN EFI_SYSTEM_TABLE  *SystemTable
> >    )
> >  {
> > +  //
> > +  // If gSmmBaseHobGuid found, means SmBase info has been relocated and
> > recorded
> > +  // in the SmBase array.
> > +  //
> > +  mSmmCpuFeaturesSmmRelocated = (BOOLEAN)(GetFirstGuidHob
> > (&gSmmBaseHobGuid) != NULL);
> > +
> 
> Do you agree just assert mSmmCpuFeaturesSmmRelocated is the false for OVMF?

Skip the indirection, just "ASSERT(GetFirstGuidHob(...) == NULL)".

take care,
  Gerd