From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io
Cc: sunilvl@ventanamicro.com, Ard Biesheuvel <ardb@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Abner Chang <abner.chang@amd.com>,
Daniel Schaefer <git@danielschaefer.me>
Subject: [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Date: Fri, 3 Feb 2023 12:08:43 +0100 [thread overview]
Message-ID: <20230203110843.2349736-1-ardb@kernel.org> (raw)
The code never references the PCD so the INF should not reference it
either. The last reference was moved to PrePiHobLib in commit
05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
commit 97106391955337155e7.
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Reported-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
1 file changed, 2 deletions(-)
diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
index 3c749ca22943..090bfe888f52 100644
--- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
+++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
@@ -58,8 +58,6 @@ [Protocols]
[FixedPcd.common]
- gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
-
gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
--
2.39.1
next reply other threads:[~2023-02-03 11:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 11:08 Ard Biesheuvel [this message]
2023-02-03 11:16 ` [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize Sunil V L
2023-02-03 11:48 ` Ard Biesheuvel
2023-02-04 1:26 ` [edk2-devel] " Michael Kubacki
2023-02-06 22:04 ` Ard Biesheuvel
2023-02-06 22:40 ` Michael Kubacki
2023-02-06 22:41 ` Ard Biesheuvel
2023-02-04 1:27 ` EDKII -CI weird issue Yao, Jiewen
2023-02-04 1:39 ` Michael D Kinney
2023-02-04 11:32 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203110843.2349736-1-ardb@kernel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox